Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix overflow key error #1786

Merged
merged 1 commit into from Aug 28, 2023
Merged

fix: fix overflow key error #1786

merged 1 commit into from Aug 28, 2023

Conversation

DaiQiangReal
Copy link
Collaborator

中文模板 / Chinese Template

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Test Case
  • TypeScript definition update
  • Document improve
  • CI/CD improve
  • Branch sync
  • Other, please describe:

PR description

Fixes #

Changelog

🇨🇳 Chinese

  • Fix: 修复 OverflowList 组件在部分场景 key 报警告的问题

🇺🇸 English

  • Fix: Fix the problem that the OverflowList component reports a warning in some scene keys

Checklist

  • Test or no need
  • Document or no need
  • Changelog or no need

Other

  • Skip Changelog

Additional information

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 97d7348:

Sandbox Source
pr-story Configuration
Semi Design: Simple Story Configuration

@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: -0.07% ⚠️

Comparison is base (cde4732) 87.99% compared to head (46a102a) 87.92%.
Report is 2 commits behind head on main.

❗ Current head 46a102a differs from pull request most recent head 97d7348. Consider uploading reports for the commit 97d7348 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1786      +/-   ##
==========================================
- Coverage   87.99%   87.92%   -0.07%     
==========================================
  Files         435      435              
  Lines       25382    25384       +2     
  Branches     6397     6399       +2     
==========================================
- Hits        22334    22320      -14     
- Misses       3048     3064      +16     
Files Changed Coverage Δ
packages/semi-ui/overflowList/index.tsx 60.43% <0.00%> (-0.89%) ⬇️

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cypress
Copy link

cypress bot commented Aug 28, 2023

Passing run #1882 ↗︎

0 214 10 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 97d7348 into 4acec82...
Project: semi-design Commit: 46a102a9ac ℹ️
Status: Passed Duration: 14:22 💡
Started: Aug 28, 2023 7:08 AM Ended: Aug 28, 2023 7:23 AM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@DaiQiangReal DaiQiangReal merged commit 473c96f into main Aug 28, 2023
10 checks passed
@DaiQiangReal DaiQiangReal deleted the fix_overflowKeyError branch August 28, 2023 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants