Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix slider tooltip blink when drag out of handle #1935

Merged
merged 2 commits into from Dec 11, 2023

Conversation

DaiQiangReal
Copy link
Collaborator

中文模板 / Chinese Template

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Test Case
  • TypeScript definition update
  • Document improve
  • CI/CD improve
  • Branch sync
  • Other, please describe:

PR description

Fixes #

Changelog

🇨🇳 Chinese

  • Fix: 修复 Slider 把手上的tooltip 在拖动时偶尔闪烁的问题

🇺🇸 English

  • Fix: Fixed the issue where the tooltip on the Slider handle occasionally flickers when dragging

Checklist

  • Test or no need
  • Document or no need
  • Changelog or no need

Other

  • Skip Changelog

Additional information

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a8d867a:

Sandbox Source
pr-story Configuration
Semi Design: Simple Story Configuration

@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (6cfb424) 88.08% compared to head (f52c098) 88.14%.
Report is 1 commits behind head on release.

❗ Current head f52c098 differs from pull request most recent head a8d867a. Consider uploading reports for the commit a8d867a to get more accurate results

Files Patch % Lines
packages/semi-ui/slider/index.tsx 75.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           release    #1935      +/-   ##
===========================================
+ Coverage    88.08%   88.14%   +0.06%     
===========================================
  Files          436      436              
  Lines        25580    25583       +3     
  Branches      6452     6453       +1     
===========================================
+ Hits         22531    22551      +20     
+ Misses        3049     3032      -17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cypress bot commented Nov 27, 2023

Passing run #2065 ↗︎

0 232 10 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge a8d867a into 4ecf544...
Project: semi-design Commit: f52c098edd ℹ️
Status: Passed Duration: 10:12 💡
Started: Nov 27, 2023 9:24 AM Ended: Nov 27, 2023 9:35 AM

Review all test suite changes for PR #1935 ↗︎

@pointhalo pointhalo merged commit c1993b6 into release Dec 11, 2023
9 checks passed
@pointhalo pointhalo deleted the fix_slider_toooltip_blink branch December 11, 2023 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants