Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add stopPropagation api to timepicker #1966

Merged
merged 4 commits into from Dec 11, 2023
Merged

Conversation

YannLynn
Copy link
Collaborator

@YannLynn YannLynn commented Dec 5, 2023

中文模板 / Chinese Template

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Test Case
  • TypeScript definition update
  • Document improve
  • CI/CD improve
  • Branch sync
  • Other, please describe:

PR description

Changelog

🇨🇳 Chinese

  • Feat: Timepicker 新增 stopPropagation 用于判断是否阻止弹出层上的点击事件冒泡

🇺🇸 English

  • Feat: Timepicker adds stopPropagation to determine whether to prevent click events on the popup layer from bubbling up.

Checklist

  • Test or no need
  • Document or no need
  • Changelog or no need

Other

  • Skip Changelog

Additional information

Copy link

codesandbox-ci bot commented Dec 5, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ae79791:

Sandbox Source
pr-story Configuration
Semi Design: Simple Story Configuration

@codecov-commenter
Copy link

codecov-commenter commented Dec 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (395ecb1) 88.10% compared to head (4987c81) 88.13%.
Report is 2 commits behind head on release.

❗ Current head 4987c81 differs from pull request most recent head ae79791. Consider uploading reports for the commit ae79791 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           release    #1966      +/-   ##
===========================================
+ Coverage    88.10%   88.13%   +0.03%     
===========================================
  Files          436      436              
  Lines        25590    25591       +1     
  Branches      6456     6457       +1     
===========================================
+ Hits         22545    22555      +10     
+ Misses        3045     3036       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cypress bot commented Dec 5, 2023

Passing run #2104 ↗︎

0 233 10 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge ae79791 into 34f8872...
Project: semi-design Commit: 4987c816e9 ℹ️
Status: Passed Duration: 09:46 💡
Started: Dec 11, 2023 3:18 AM Ended: Dec 11, 2023 3:28 AM

Review all test suite changes for PR #1966 ↗︎

@pointhalo pointhalo merged commit c555f8b into release Dec 11, 2023
9 checks passed
@pointhalo pointhalo deleted the feat-timepicker-stoppro branch December 11, 2023 04:22
@xmsz-stu
Copy link

stopPropagation的类型现在是必选了

@YannLynn
Copy link
Collaborator Author

stopPropagation的类型现在是必选了

版本 2.50.0-beta.0 更正了这个问题哈。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants