Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better typography #1970

Merged
merged 10 commits into from Feb 8, 2024
Merged

Better typography #1970

merged 10 commits into from Feb 8, 2024

Conversation

DaiQiangReal
Copy link
Collaborator

@DaiQiangReal DaiQiangReal commented Dec 8, 2023

中文模板 / Chinese Template

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Test Case
  • TypeScript definition update
  • Document improve
  • CI/CD improve
  • Branch sync
  • Other, please describe:

PR description

Fixes #

Changelog

🇨🇳 Chinese

  • Perf: 提升 Typography 开启 Ellipsis 下 性能,减少 render 和计算次数

🇺🇸 English

  • Perf: Improve the performance of Typography when Ellipsis is turned on, and reduce the number of renders and calculations

Checklist

  • Test or no need
  • Document or no need
  • Changelog or no need

Other

  • Skip Changelog

Additional information

Copy link

codesandbox-ci bot commented Dec 8, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 8322cd4:

Sandbox Source
Semi Design: Simple Story Configuration

Copy link

cypress bot commented Dec 8, 2023

Passing run #2280 ↗︎

0 223 10 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 8322cd4 into d8f24f2...
Project: semi-design Commit: f52ddf5e5b ℹ️
Status: Passed Duration: 08:13 💡
Started: Feb 7, 2024 10:32 AM Ended: Feb 7, 2024 10:40 AM

Review all test suite changes for PR #1970 ↗︎

@marshcat0
Copy link
Contributor

这个MR这么久没有合并,是有啥问题吗?

@DaiQiangReal
Copy link
Collaborator Author

这个MR这么久没有合并,是有啥问题吗?

Review 的人力最近不充足。。。

@DaiQiangReal
Copy link
Collaborator Author

@marshcat0
Copy link
Contributor

Copy link

cypress bot commented Feb 7, 2024

1 failed test on run #2264 ↗︎

1 222 10 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge pull request #2068 from DouyinFE/remove_resizeObserver_polyfill
Project: semi-design Commit: fd3a80e7b0
Status: Failed Duration: 08:12 💡
Started: Feb 7, 2024 7:56 AM Ended: Feb 7, 2024 8:04 AM

Review all test suite changes for PR #1970 ↗︎

@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (d8f24f2) 87.28% compared to head (f52ddf5) 87.31%.

❗ Current head f52ddf5 differs from pull request most recent head 8322cd4. Consider uploading reports for the commit 8322cd4 to get more accurate results

Files Patch % Lines
packages/semi-ui/resizeObserver/index.tsx 82.35% 3 Missing ⚠️
packages/semi-ui/typography/base.tsx 88.88% 3 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           release    #1970      +/-   ##
===========================================
+ Coverage    87.28%   87.31%   +0.03%     
===========================================
  Files          439      439              
  Lines        25826    25861      +35     
  Branches      6567     6574       +7     
===========================================
+ Hits         22541    22581      +40     
+ Misses        3285     3280       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pointhalo pointhalo merged commit c638a58 into release Feb 8, 2024
8 of 9 checks passed
@pointhalo pointhalo deleted the better_typography branch February 8, 2024 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants