Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: improve the performance of Cascader under leafOnly, Multi-selec… #1999

Merged
merged 3 commits into from Jan 9, 2024

Conversation

YyumeiZhang
Copy link
Collaborator

@YyumeiZhang YyumeiZhang commented Dec 27, 2023

…t searchable, and controlled situation

中文模板 / Chinese Template

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Test Case
  • TypeScript definition update
  • Document improve
  • CI/CD improve
  • Branch sync
  • Other, please describe:

PR description

Fixes #

Changelog

🇨🇳 Chinese

  • Perf: 优化 Cascader 在多选,leafOnly,可搜索,受控情况下千级叶子节点被选中时的卡顿问题

🇺🇸 English

  • Perf: Optimize Cascader's stuck problem when a thousands of leaf nodes are selected under multi-selection, leafOnly, searchable, and controlled conditions

Checklist

  • Test or no need
  • Document or no need
  • Changelog or no need

Other

  • Skip Changelog

Additional information

Copy link

codesandbox-ci bot commented Dec 27, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 3392772:

Sandbox Source
pr-story Configuration
Semi Design: Simple Story Configuration

Copy link

cypress bot commented Dec 27, 2023

Passing run #2146 ↗︎

0 237 10 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 59a6fb6 into 0e77d9e...
Project: semi-design Commit: 8912ba82c8 ℹ️
Status: Passed Duration: 09:54 💡
Started: Dec 27, 2023 11:26 AM Ended: Dec 27, 2023 11:36 AM

Review all test suite changes for PR #1999 ↗︎

@codecov-commenter
Copy link

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (14bfd1a) 88.16% compared to head (8912ba8) 88.23%.
Report is 9 commits behind head on main.

❗ Current head 8912ba8 differs from pull request most recent head 59a6fb6. Consider uploading reports for the commit 59a6fb6 to get more accurate results

Files Patch % Lines
packages/semi-ui/treeSelect/index.tsx 88.88% 7 Missing ⚠️
packages/semi-foundation/cascader/util.ts 81.81% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1999      +/-   ##
==========================================
+ Coverage   88.16%   88.23%   +0.07%     
==========================================
  Files         436      436              
  Lines       25592    25624      +32     
  Branches     6472     6486      +14     
==========================================
+ Hits        22563    22610      +47     
+ Misses       3029     3014      -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pointhalo pointhalo merged commit dd2d532 into main Jan 9, 2024
5 of 6 checks passed
@pointhalo pointhalo deleted the find/cascader-op branch January 9, 2024 11:38
@YyumeiZhang YyumeiZhang mentioned this pull request Jan 29, 2024
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants