Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix the problem of indentation error of tree when renderingFullL… #2007

Merged
merged 1 commit into from Jan 3, 2024

Conversation

YyumeiZhang
Copy link
Collaborator

…abel

中文模板 / Chinese Template

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Test Case
  • TypeScript definition update
  • Document improve
  • CI/CD improve
  • Branch sync
  • Other, please describe:

PR description

Fixes #

Changelog

🇨🇳 Chinese

  • Fix: 修复 Tree 在支持 showLine 后, renderFullLabel 时缩进错误问题 (影响范围:v2.50.0)
  • Fix: 修复 Tree 在支持 showLine 后, rtl 模式下连接线和选项文字部分重合问题(影响范围:v2.50.0)

🇺🇸 English

  • Fix: Fix the indentation error problem when renderingFullLabel after Tree supports showLine(scope of impact: v2.50.0)
  • Fix: After Tree supports showLine, the connection line and option text partially overlap in rtl mode.(scope of impact: v2.50.0)

Checklist

  • Test or no need
  • Document or no need
  • Changelog or no need

Other

  • Skip Changelog

Additional information

Copy link

codesandbox-ci bot commented Jan 3, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0d06350:

Sandbox Source
pr-story Configuration
Semi Design: Simple Story Configuration

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4532ad0) 88.29% compared to head (3a29ce1) 88.26%.

❗ Current head 3a29ce1 differs from pull request most recent head 0d06350. Consider uploading reports for the commit 0d06350 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2007      +/-   ##
==========================================
- Coverage   88.29%   88.26%   -0.04%     
==========================================
  Files         437      437              
  Lines       25645    25645              
  Branches     6492     6492              
==========================================
- Hits        22644    22636       -8     
- Misses       3001     3009       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cypress bot commented Jan 3, 2024

Passing run #2152 ↗︎

0 237 10 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 0d06350 into 4532ad0...
Project: semi-design Commit: 3a29ce14c2 ℹ️
Status: Passed Duration: 10:34 💡
Started: Jan 3, 2024 10:01 AM Ended: Jan 3, 2024 10:12 AM

Review all test suite changes for PR #2007 ↗︎

@pointhalo pointhalo merged commit 9582f78 into main Jan 3, 2024
11 checks passed
@pointhalo pointhalo deleted the fix/tree-renderFullLabel branch January 3, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants