Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix select border token #2065

Merged
merged 3 commits into from Feb 6, 2024
Merged

fix: fix select border token #2065

merged 3 commits into from Feb 6, 2024

Conversation

DaiQiangReal
Copy link
Collaborator

中文模板 / Chinese Template

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Test Case
  • TypeScript definition update
  • Document improve
  • CI/CD improve
  • Branch sync
  • Other, please describe:

PR description

Fixes #

Changelog

🇨🇳 Chinese

  • Fix: 修复 Select 部分 border width token 不正确的问题

🇺🇸 English

  • Fix: Fix the issue of incorrect border width token in Select part

Checklist

  • Test or no need
  • Document or no need
  • Changelog or no need

Other

  • Skip Changelog

Additional information

Copy link

codesandbox-ci bot commented Feb 5, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 81b5d85:

Sandbox Source
pr-story Configuration
Semi Design: Simple Story Configuration

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (91329ab) 87.30% compared to head (6532fb5) 87.32%.

❗ Current head 6532fb5 differs from pull request most recent head f20d500. Consider uploading reports for the commit f20d500 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           release    #2065      +/-   ##
===========================================
+ Coverage    87.30%   87.32%   +0.01%     
===========================================
  Files          438      438              
  Lines        25761    25761              
  Branches      6556     6556              
===========================================
+ Hits         22491    22496       +5     
+ Misses        3270     3265       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cypress bot commented Feb 5, 2024

Passing run #2246 ↗︎

0 220 10 0 Flakiness 0

Details:

Merge f20d500 into 91329ab...
Project: semi-design Commit: 6532fb5f58 ℹ️
Status: Passed Duration: 08:16 💡
Started: Feb 5, 2024 4:14 AM Ended: Feb 5, 2024 4:22 AM

Review all test suite changes for PR #2065 ↗︎

@pointhalo
Copy link
Collaborator

#570 中,将输入类组件的 border width 由统一一个token 拆分成每个组件单独使用自己的token,但是select这里应该是改漏了一处,只修改了 :focus内的,但是 -focus 的没有修改,依然使用的是全局token,而非组件级token

会导致用户如果在 DSM 中将width 相关组件级 token改为0后,不然不生效。本次修改是为了解决该问题,

@pointhalo pointhalo merged commit e558b07 into release Feb 6, 2024
6 checks passed
@pointhalo pointhalo deleted the fix_select_borderToken branch February 6, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants