Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: when using timeZone and disabledHours at the same time in timepicker display value does not meet expectations #2083

Merged
merged 1 commit into from Feb 26, 2024

Conversation

YannLynn
Copy link
Collaborator

@YannLynn YannLynn commented Feb 21, 2024

中文模板 / Chinese Template

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Test Case
  • TypeScript definition update
  • Document improve
  • CI/CD improve
  • Branch sync
  • Other, please describe:

PR description

Fixes #2082
判断 hours 是否合法时,需要用当前 Timepicker 下 timezone 时区的选择值去判断。
如当前选择 7:14, 比较 hour 的值也应该为 7 。

Changelog

🇨🇳 Chinese

  • Fix: 修复 Timepicker 中同时使用 timeZone 和 disabledHours 时显示值不符合预期问题

🇺🇸 English

  • Fix: the problem that when using timeZone and disabledHours at the same time in Timepicker, the displayed value does not meet the expectations

Checklist

  • Test or no need
  • Document or no need
  • Changelog or no need

Other

  • Skip Changelog

Additional information

…cker display value does not meet expectations
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5303da8:

Sandbox Source
pr-story Configuration

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cefdb56) 87.38% compared to head (b0246e8) 87.30%.
Report is 71 commits behind head on main.

❗ Current head b0246e8 differs from pull request most recent head 5303da8. Consider uploading reports for the commit 5303da8 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2083      +/-   ##
==========================================
- Coverage   87.38%   87.30%   -0.08%     
==========================================
  Files         437      438       +1     
  Lines       25685    25796     +111     
  Branches     6508     6564      +56     
==========================================
+ Hits        22445    22522      +77     
- Misses       3240     3274      +34     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cypress bot commented Feb 21, 2024

Passing run #2297 ↗︎

0 224 10 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 5303da8 into cf58c76...
Project: semi-design Commit: b0246e8579 ℹ️
Status: Passed Duration: 08:20 💡
Started: Feb 21, 2024 8:04 AM Ended: Feb 21, 2024 8:12 AM

Review all test suite changes for PR #2083 ↗︎

@YannLynn YannLynn merged commit d7a4270 into main Feb 26, 2024
10 checks passed
@YannLynn YannLynn deleted the fix-2082 branch February 26, 2024 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TimePicker] use timeZone and disabledHours at the same time results in incorrect and illegal display time.
3 participants