Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix TypeError in Cascader when value is not in TreeData #2146

Merged
merged 1 commit into from Apr 2, 2024

Conversation

YyumeiZhang
Copy link
Collaborator

中文模板 / Chinese Template

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Test Case
  • TypeScript definition update
  • Document improve
  • CI/CD improve
  • Branch sync
  • Other, please describe:

PR description

Fixes #

Changelog

🇨🇳 Chinese

  • Fix: 修复受控 Cascader 中 value 不在 TreeData 内时的类型错误

🇺🇸 English

  • Fix: Fix type error in controlled Cascader where value is not in TreeData

Checklist

  • Test or no need
  • Document or no need
  • Changelog or no need

Other

  • Skip Changelog

Additional information

Copy link

codesandbox-ci bot commented Apr 1, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6779238:

Sandbox Source
pr-story Configuration

Copy link

cypress bot commented Apr 1, 2024

Passing run #2389 ↗︎

0 252 10 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 6779238 into b164af4...
Project: semi-design Commit: 3691f9bf48 ℹ️
Status: Passed Duration: 10:07 💡
Started: Apr 1, 2024 9:26 AM Ended: Apr 1, 2024 9:36 AM

Review all test suite changes for PR #2146 ↗︎

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 90.90909% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 88.20%. Comparing base (581dd41) to head (3691f9b).
Report is 12 commits behind head on main.

❗ Current head 3691f9b differs from pull request most recent head 6779238. Consider uploading reports for the commit 6779238 to get more accurate results

Files Patch % Lines
packages/semi-foundation/select/foundation.ts 83.33% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2146      +/-   ##
==========================================
+ Coverage   88.17%   88.20%   +0.03%     
==========================================
  Files         440      440              
  Lines       25937    25945       +8     
  Branches     6603     6606       +3     
==========================================
+ Hits        22869    22884      +15     
+ Misses       3068     3061       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DaiQiangReal DaiQiangReal merged commit 6fcab0b into main Apr 2, 2024
9 checks passed
@DaiQiangReal DaiQiangReal deleted the fix/cascader-value-not-in-treedata branch April 2, 2024 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants