Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix the abnormal expansion status of selected options after sele… #2179

Merged
merged 2 commits into from Apr 19, 2024

Conversation

YyumeiZhang
Copy link
Collaborator

…cting options in single selection, filterTreeNode, and loadData TreeSelect

中文模板 / Chinese Template

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Test Case
  • TypeScript definition update
  • Document improve
  • CI/CD improve
  • Branch sync
  • Other, please describe:

PR description

Fixes #2178

Changelog

🇨🇳 Chinese


🇺🇸 English

Checklist

  • Test or no need
  • Document or no need
  • Changelog or no need

Other

  • Skip Changelog

Additional information

…cting options in single selection, filterTreeNode, and loadData TreeSelect
Copy link

codesandbox-ci bot commented Apr 17, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 1d87de2:

Sandbox Source
pr-story Configuration

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 77.27273% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 87.61%. Comparing base (c2d893b) to head (a08e847).

❗ Current head a08e847 differs from pull request most recent head 6979b04. Consider uploading reports for the commit 6979b04 to get more accurate results

Files Patch % Lines
packages/semi-foundation/treeSelect/foundation.ts 78.57% 3 Missing ⚠️
packages/semi-ui/treeSelect/index.tsx 75.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2179      +/-   ##
==========================================
- Coverage   88.15%   87.61%   -0.55%     
==========================================
  Files         440      440              
  Lines       26000    26012      +12     
  Branches     6631     6632       +1     
==========================================
- Hits        22921    22790     -131     
- Misses       3079     3222     +143     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cypress bot commented Apr 17, 2024

Passing run #2430 ↗︎

0 244 10 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 6979b04 into c2d893b...
Project: semi-design Commit: a08e847287 ℹ️
Status: Passed Duration: 10:01 💡
Started: Apr 17, 2024 2:13 PM Ended: Apr 17, 2024 2:23 PM

Review all test suite changes for PR #2179 ↗︎

…cting options in single selection, filterTreeNode, and loadData TreeSelect
@DaiQiangReal DaiQiangReal merged commit 2b13d25 into main Apr 19, 2024
7 checks passed
@DaiQiangReal DaiQiangReal deleted the fix/2178 branch April 19, 2024 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TreeSelect] 可搜索,异步加载数据的 TreeSelect,选择选项后,选项展开异常
3 participants