Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix tooltip not show when already hover on mount #2199

Merged
merged 1 commit into from Apr 25, 2024

Conversation

DaiQiangReal
Copy link
Collaborator

中文模板 / Chinese Template

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Test Case
  • TypeScript definition update
  • Document improve
  • CI/CD improve
  • Branch sync
  • Other, please describe:

PR description

Fixes #

Changelog

🇨🇳 Chinese

  • Fix: 修复 Tooltip 在挂载时,如果 Cursor 已经在 trigger 的 dom 上,且 React 复用了 trigger dom 作为 tooltip 的 children,tooltip 不会展示的问题

🇺🇸 English

  • Fix: Fix the problem that when the Tooltip is mounted, if the Cursor is already on the dom of the trigger, and React reuses the trigger dom as the children of the tooltip, the tooltip will not be displayed.

Checklist

  • Test or no need
  • Document or no need
  • Changelog or no need

Other

  • Skip Changelog

Additional information

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b23a774:

Sandbox Source
pr-story Configuration

@DaiQiangReal
Copy link
Collaborator Author

simplescreenrecorder-2024-04-24_17.58.07.mp4

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 72.72727% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 88.24%. Comparing base (b2cd10b) to head (379eb17).

❗ Current head 379eb17 differs from pull request most recent head b23a774. Consider uploading reports for the commit b23a774 to get more accurate results

Files Patch % Lines
packages/semi-foundation/tooltip/foundation.ts 40.00% 3 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2199      +/-   ##
==========================================
+ Coverage   88.21%   88.24%   +0.03%     
==========================================
  Files         440      440              
  Lines       26007    26018      +11     
  Branches     6636     6639       +3     
==========================================
+ Hits        22941    22959      +18     
+ Misses       3066     3059       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cypress bot commented Apr 24, 2024

1 failed test on run #2459 ↗︎

1 257 10 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge b23a774 into b2cd10b...
Project: semi-design Commit: 379eb170e3 ℹ️
Status: Failed Duration: 11:01 💡
Started: Apr 24, 2024 9:53 AM Ended: Apr 24, 2024 10:04 AM

Review all test suite changes for PR #2199 ↗︎

@pointhalo pointhalo merged commit 8fc0554 into main Apr 25, 2024
8 of 10 checks passed
@pointhalo pointhalo deleted the fix_tooltip_notShowWhenAlreadyHoverOnMount branch April 25, 2024 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants