Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: fix tagInput insetLabel not align with other component #2216

Merged
merged 1 commit into from
May 6, 2024

Conversation

pointhalo
Copy link
Collaborator

@pointhalo pointhalo commented May 6, 2024

中文模板 / Chinese Template

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Test Case
  • TypeScript definition update
  • Document improve
  • CI/CD improve
  • Branch sync
  • Other, please describe:

PR description

其他组件如 input、select 等支持 insetLabel的组件,在 xx-inset-label 的 classname上均会带有 font-size的声明,不会受到 body fontsize继承的影响。而tagInput表现与其他组件不一致。需要对齐。

Changelog

🇨🇳 Chinese

  • Style: 修复 TagIput 在 Form 表单中使用 insetLabel时,样式与其他组件未对齐的问题
  • Design Token:TagInput 增加 $color-tagInput_prefix-text-default、$spacing-tagInput_insetLabel-marginRight、$font-tagInput_insetLabel-fontWeight 三个 Token

🇺🇸 English

  • Style: fixed TagInput insetLabel style not align with other component such as Input、Select
  • Design Token:TagInput add Tokens:$color-tagInput_prefix-text-default、$spacing-tagInput_insetLabel-marginRight、$font-tagInput_insetLabel-fontWeight

Checklist

  • Test or no need
  • Document or no need
  • Changelog or no need

Other

  • Skip Changelog

Additional information

Copy link

codesandbox-ci bot commented May 6, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 09a26fa:

Sandbox Source
pr-story Configuration

@pointhalo pointhalo requested a review from YyumeiZhang May 6, 2024 08:32
@pointhalo pointhalo merged commit a154de7 into main May 6, 2024
8 checks passed
@pointhalo pointhalo deleted the style-tagInputInsetLabel branch May 6, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant