Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(foundation): word spelling #660

Merged
merged 3 commits into from May 6, 2022

Conversation

chenzn1
Copy link
Contributor

@chenzn1 chenzn1 commented Feb 24, 2022

中文模板 / Chinese Template

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • [ x ] Code style update
  • Refactor
  • Test Case
  • TypeScript definition update
  • Document improve
  • CI/CD improve
  • Branch sync
  • Other, please describe:

PR description

Fixes #

Changelog

🇨🇳 Chinese

  • Fix(foundation): 大批量的修复 foundation 的单词拼写错误

🇺🇸 English

  • Fix: fix ...

Checklist

  • Test or no need
  • Document or no need
  • Changelog or no need

Other

  • Skip Changelog

Additional information

@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 24, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 11d15c3:

Sandbox Source
DouyinFE/semi-design Configuration
Semi Design: Simple Story Configuration

@codecov-commenter
Copy link

codecov-commenter commented Feb 24, 2022

Codecov Report

Merging #660 (44e00c5) into main (663a62a) will not change coverage.
The diff coverage is 85.88%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #660   +/-   ##
=======================================
  Coverage   81.69%   81.69%           
=======================================
  Files         365      365           
  Lines       20492    20492           
  Branches     5226     5226           
=======================================
  Hits        16740    16740           
  Misses       3732     3732           
  Partials       20       20           
Impacted Files Coverage Δ
...mi-foundation/datePicker/yearAndMonthFoundation.ts 21.42% <ø> (ø)
packages/semi-foundation/form/foundation.ts 87.17% <ø> (ø)
packages/semi-foundation/input/constants.ts 100.00% <ø> (ø)
...ges/semi-foundation/timePicker/ComboxFoundation.ts 84.37% <0.00%> (ø)
packages/semi-foundation/timePicker/constants.ts 100.00% <ø> (ø)
packages/semi-foundation/timePicker/foundation.ts 81.01% <0.00%> (ø)
packages/semi-foundation/transfer/foundation.ts 76.92% <ø> (ø)
packages/semi-foundation/transfer/transferUtils.ts 100.00% <ø> (ø)
packages/semi-foundation/treeSelect/constants.ts 100.00% <ø> (ø)
packages/semi-foundation/upload/utils.ts 17.64% <0.00%> (ø)
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 663a62a...44e00c5. Read the comment docs.

@pointhalo
Copy link
Collaborator

非常抱歉过了这么久才处理这个PR 🙏

有部分修改我们认为应该保留现状,因此我追加了一个commit将这部分进行了回退。

  • input/constant CLEARBTN_CLICKED_EVENT_FLAG 保持不变
  • tabs/fooundation isControlledComponent是表示是否为受控组件,这个原有的单词拼写有误。不过 改成isContortedComponent 其实也是不对的,这里重新修改了一下

其他修改没有问题,直接合入了。

感谢贡献代码 ❤️

@pointhalo pointhalo merged commit 5b0cc11 into DouyinFE:main May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants