Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TypeScript type declarations #2

Merged
merged 1 commit into from
Sep 1, 2019
Merged

Add TypeScript type declarations #2

merged 1 commit into from
Sep 1, 2019

Conversation

jirutka
Copy link
Collaborator

@jirutka jirutka commented Aug 27, 2019

Please release a new version after merging, so I can already start using it.

Copy link
Owner

@Download Download left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am no TypeScript user, but this looks like great work!

@Download Download merged commit 0231606 into Download:master Sep 1, 2019
@Download
Copy link
Owner

Download commented Sep 1, 2019

Released in 0.18.0
Also published to NPM
Thank you for your contribution Jakub!

@jirutka jirutka deleted the typescript branch September 1, 2019 21:33
@Download
Copy link
Owner

Download commented Sep 1, 2019

@jirutka
Jakub I invited you as a collaborator because of your great contribution. 👍

Please feel free to create a new PR when you have something else to add, or use your new powers (should you accept them) to merge the work of other people. I only ask that we try to maintain a 2-pair-of-eyes principle: we don't directly merge our own work but instead invite someone else to review it and merge it. Welcome aboard!

-Stijn

@jirutka
Copy link
Collaborator Author

jirutka commented Sep 2, 2019

Jakub I invited you as a collaborator because of your great contribution. +1
Oh, thank you! 😺

I only ask that we try to maintain a 2-pair-of-eyes principle: we don't directly merge our own work but instead invite someone else to review it and merge it.

That’s a good approach, I will stick to it!


Could you please also resolve Download/ulog#21?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants