#642 Support the conversion of String In Map To Enum #643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garethahealy
reviewed
Jun 9, 2018
| || Character.class.equals(aClass) | ||
| || Boolean.class.equals(aClass) | ||
| || java.util.Date.class.isAssignableFrom(aClass) | ||
| || java.util.Calendar.class.isAssignableFrom(aClass); |
There was a problem hiding this comment.
Can you add aClass.isEnum() at the end so the diff, is just 1 line, instead of 7
| testEnumMapsToNonexistEnumValueEE.expectMessage("No enum constant com.github.dozermapper.core.vo.enumtest.DestType.BAR"); | ||
| testEnumMapsToNonexistEnumValueEE.expect(IllegalArgumentException.class); | ||
| testEnumMapsToNonexistEnumValueEE.expectMessage("Cannot convert [BAR] to enum of type class com.github.dozermapper.core.vo.enumtest.DestType"); | ||
| testEnumMapsToNonexistEnumValueEE.expect(MappingException.class); |
There was a problem hiding this comment.
IllegalArgumentException is caught in com.github.dozermapper.core.converters.EnumConverter#convert and then it is wrapped in MappingException and threw out.
So the expected exception should be MappingException, not the original IllegalArgumentException.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link
#642 Support the conversion of String In Map To Enum
Purpose
Support the conversion of String In Map To Enum
Approach
Make PrimitiveOrWrapperConverter accepts Enum type for destination object.
Open Questions and Pre-Merge TODOs