Use custom non-mutating memoization #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #102 +/- ##
==========================================
+ Coverage 94.16% 94.56% +0.40%
==========================================
Files 14 14
Lines 1251 1344 +93
==========================================
+ Hits 1178 1271 +93
Misses 73 73
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Remove use of nexprs in _calc_outs
Rm ChainRulesCore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if this has any benefits at the moment, so I might just keep it here in case Zygote removes support forDictmutation or if Diffractor takes off (and does not supportDictmutation).Seems to be better than the baseline now with some tweaks. There are still a couple of permutations on how to split it up which might be worth trying out.
Need to think about whether removing support for gradient of
output!is considered breaking.I guess it is in the strictest sense so I should probably add back that code if I merge this before any of the two above happen.Changed my mind on the above.
output!is not exported in the main module. It is also very unlikely that someone would need gradients for it since it is more about collecting all activations.