clean up nasty old code that used UNIVERSAL

CHANGELOG

@@ -1,3 +1,5 @@
+2016-09-27      1.04    Clean up some nasty old code, no functional changes
+
 2015-11-22      1.03    Fix tests to work with perl 5.22 and higher
 
 2008-06-16      1.02    Remove more 'use diagnostics' (and forgot to update

Makefile.PL

@@ -10,6 +10,7 @@ WriteMakefile(
     },
     VERSION_FROM => 'lib/Data/Transactional.pm',
     PREREQ_PM    => {
+	'Scalar::Util'     => 0,
         Storable           => 2.07,  # we use dclone()
         'Data::Compare'    => 0.11,  # used for testing,
                                      # and by D:C:Plugins:D:T

lib/Data/Compare/Plugins/Data/Transactional.pm

@@ -4,9 +4,9 @@ use strict;
 use warnings;
 
 use Data::Compare;
-use UNIVERSAL;
+use Scalar::Util qw(blessed);
 
-our $VERSION = '1.03';
+our $VERSION = '1.04';
 
 sub _register {
     return
@@ -24,7 +24,7 @@ sub _dt_dt_compare {
 
 sub _dt_notdt_compare {
     my($dt, $notdt) = @_;
-    ($dt, $notdt) = ($notdt, $dt) if(!UNIVERSAL::isa($dt, 'Data::Transactional'));
+    ($dt, $notdt) = ($notdt, $dt) if(!(blessed($dt) && $dt->isa('Data::Transactional')));
     Compare(_underlying($dt), $notdt);
 }
 

lib/Data/Transactional.pm

@@ -3,7 +3,7 @@ package Data::Transactional;
 use strict;
 use warnings;
 
-our $VERSION = '1.03';
+our $VERSION = '1.04';
 
 use Data::Dumper;
 

t/04_dt_magic.t

@@ -5,21 +5,21 @@ use warnings;
 
 use Data::Dumper;
 use Data::Compare;
-use Test::More tests => 16;
+use Scalar::Util qw(blessed);
+use Test::More tests => 17;
 
-use UNIVERSAL;
 use Data::Transactional;
 
 my $tied = Data::Transactional->new(type => 'array');
 
-ok(UNIVERSAL::isa($tied, 'Data::Transactional'), "object has right type");
+ok(ref($tied) eq 'Data::Transactional', "array object has right type");
 foreach my $method (qw(rollback commit checkpoint commit_all rollback_all)) {
-    ok(UNIVERSAL::can($tied, $method), "got a $method method");
+    ok($tied->can($method), "got a $method method");
 }
-
 ok(Compare($tied, []), "newly created transactional array is empty");
 
 $tied = Data::Transactional->new(); # hash
+ok(ref($tied) eq 'Data::Transactional', "hash object has right type");
 ok(Compare($tied, {}), "newly created transactional hash is empty");
 
 eval { $tied->rollback(); };