Merge pull request #11 from daleevans/strict-warnings

use strict / use warnings
DrHyde · Mar 7, 2015 · 2f1b03f · 2f1b03f
2 parents 98045de + 2702bef
commit 2f1b03f
Show file tree

Hide file tree

Showing 71 changed files with 191 additions and 69 deletions.
diff --git a/lib/Devel/AssertOS.pm b/lib/Devel/AssertOS.pm
@@ -3,13 +3,9 @@ package Devel::AssertOS;
 use Devel::CheckOS;
 
 use strict;
+use warnings;
 
-use vars qw($VERSION);
-
-$VERSION = '1.21';
-
-# localising prevents the warningness leaking out of this module
-local $^W = 1;    # use warnings is a 5.6-ism
+our $VERSION = '1.21';
 
 =head1 NAME
 

diff --git a/lib/Devel/AssertOS/AIX.pm b/lib/Devel/AssertOS/AIX.pm
@@ -1,8 +1,10 @@
 package Devel::AssertOS::AIX;
 
 use Devel::CheckOS;
+use strict;
+use warnings;
 
-$VERSION = '1.2';
+our $VERSION = '1.2';
 
 sub os_is { $^O =~ /^aix$/i ? 1 : 0; }
 

diff --git a/lib/Devel/AssertOS/Amiga.pm b/lib/Devel/AssertOS/Amiga.pm
@@ -1,8 +1,10 @@
 package Devel::AssertOS::Amiga;
 
 use Devel::CheckOS;
+use strict;
+use warnings;
 
-$VERSION = '1.2';
+our $VERSION = '1.2';
 
 sub os_is { $^O =~ /^amigaos$/i ? 1 : 0; }
 

diff --git a/lib/Devel/AssertOS/Android.pm b/lib/Devel/AssertOS/Android.pm
@@ -1,8 +1,10 @@
 package Devel::AssertOS::Android;
 
 use Devel::CheckOS;
+use strict;
+use warnings;
 
-$VERSION = '1.2';
+our $VERSION = '1.2';
 
 sub os_is { $^O =~ /^android$/i ? 1 : 0; }
 

diff --git a/lib/Devel/AssertOS/Apple.pm b/lib/Devel/AssertOS/Apple.pm
@@ -3,8 +3,10 @@
 package Devel::AssertOS::Apple;
 
 use Devel::CheckOS;
+use strict;
+use warnings;
 
-$VERSION = '1.2';
+our $VERSION = '1.2';
 
 sub matches { return qw(MacOSX MacOSclassis); }
 sub os_is { Devel::CheckOS::os_is(matches()); }

diff --git a/lib/Devel/AssertOS/BSDOS.pm b/lib/Devel/AssertOS/BSDOS.pm
@@ -1,8 +1,10 @@
 package Devel::AssertOS::BSDOS;
 
 use Devel::CheckOS;
+use strict;
+use warnings;
 
-$VERSION = '1.2';
+our $VERSION = '1.2';
 
 sub os_is { $^O =~ /^bsdos$/i ? 1 : 0; }
 

diff --git a/lib/Devel/AssertOS/BeOS.pm b/lib/Devel/AssertOS/BeOS.pm
@@ -1,8 +1,10 @@
 package Devel::AssertOS::BeOS;
 
 use Devel::CheckOS;
+use strict;
+use warnings;
 
-$VERSION = '1.4';
+our $VERSION = '1.4';
 
 # weird special case, not quite like other OS modules, as this is both
 # an OS *and* a family - maybe this should be fixed at some point

diff --git a/lib/Devel/AssertOS/Bitrig.pm b/lib/Devel/AssertOS/Bitrig.pm
@@ -1,8 +1,10 @@
 package Devel::AssertOS::Bitrig;
 
 use Devel::CheckOS;
+use strict;
+use warnings;
 
-$VERSION = '1.0';
+our $VERSION = '1.0';
 
 sub os_is { $^O =~ /^BITRIG$/i ? 1 : 0; }
 

diff --git a/lib/Devel/AssertOS/Cygwin.pm b/lib/Devel/AssertOS/Cygwin.pm
@@ -1,8 +1,10 @@
 package Devel::AssertOS::Cygwin;
 
 use Devel::CheckOS;
+use strict;
+use warnings;
 
-$VERSION = '1.3';
+our $VERSION = '1.3';
 
 sub os_is { $^O =~ /^cygwin$/i ? 1 : 0; }
 

diff --git a/lib/Devel/AssertOS/DEC.pm b/lib/Devel/AssertOS/DEC.pm
@@ -3,8 +3,10 @@
 package Devel::AssertOS::DEC;
 
 use Devel::CheckOS;
+use strict;
+use warnings;
 
-$VERSION = '1.4';
+our $VERSION = '1.4';
 
 sub matches { return qw(OSF VMS); }
 sub os_is { Devel::CheckOS::os_is(matches()); }

diff --git a/lib/Devel/AssertOS/DGUX.pm b/lib/Devel/AssertOS/DGUX.pm
@@ -1,8 +1,10 @@
 package Devel::AssertOS::DGUX;
 
 use Devel::CheckOS;
+use strict;
+use warnings;
 
-$VERSION = '1.2';
+our $VERSION = '1.2';
 
 sub os_is { $^O =~ /^dgux$/i ? 1 : 0; }
 

diff --git a/lib/Devel/AssertOS/DragonflyBSD.pm b/lib/Devel/AssertOS/DragonflyBSD.pm
@@ -1,8 +1,10 @@
 package Devel::AssertOS::DragonflyBSD;
 
 use Devel::CheckOS;
+use strict;
+use warnings;
 
-$VERSION = '1.2';
+our $VERSION = '1.2';
 
 sub os_is { $^O =~ /^dragonfly$/i ? 1 : 0; }
 

diff --git a/lib/Devel/AssertOS/Dynix.pm b/lib/Devel/AssertOS/Dynix.pm
@@ -1,8 +1,10 @@
 package Devel::AssertOS::Dynix;
 
 use Devel::CheckOS;
+use strict;
+use warnings;
 
-$VERSION = '1.2';
+our $VERSION = '1.2';
 
 sub os_is { $^O =~ /^dynixptx$/i ? 1 : 0; }
 

diff --git a/lib/Devel/AssertOS/EBCDIC.pm b/lib/Devel/AssertOS/EBCDIC.pm
@@ -1,8 +1,10 @@
 package Devel::AssertOS::EBCDIC;
 
 use Devel::CheckOS;
+use strict;
+use warnings;
 
-$VERSION = '1.0';
+our $VERSION = '1.0';
 
 # list of OSes lifted from Module::Build 0.2808
 #

diff --git a/lib/Devel/AssertOS/Extending.pod b/lib/Devel/AssertOS/Extending.pod
@@ -26,7 +26,9 @@ called Devel::AssertOS::PlatformName which looks like:
 
     package Devel::AssertOS::Linux;
     use Devel::CheckOS;
-    $VERSION = '1.0';
+    use strict;
+    use warnings;
+    our $VERSION = '1.0';
     sub os_is { $^O =~ /^linux$/i ? 1 : 0; }
     Devel::CheckOS::die_unsupported() unless(os_is());
     1;
@@ -54,7 +56,9 @@ match any of several values of C<$^O> like this:
 
     package Devel::AssertOS::FreeSoftware;
     use Devel::CheckOS;
-    $VERSION = '1.0';
+    use strict;
+    use warnings;
+    our $VERSION = '1.0';
     sub matches { return qw(Linux FreeBSD NetBSD OpenBSD DragonflyBSD); }
     sub os_is { Devel::CheckOS::os_is(matches()); }
     sub expn { "The operating system is free-as-in-beer" }

diff --git a/lib/Devel/AssertOS/FreeBSD.pm b/lib/Devel/AssertOS/FreeBSD.pm
@@ -1,8 +1,10 @@
 package Devel::AssertOS::FreeBSD;
 
 use Devel::CheckOS;
+use strict;
+use warnings;
 
-$VERSION = '1.2';
+our $VERSION = '1.2';
 
 sub os_is { $^O =~ /^(gnuk)?freebsd$/i ? 1 : 0; }
 

diff --git a/lib/Devel/AssertOS/GNUkFreeBSD.pm b/lib/Devel/AssertOS/GNUkFreeBSD.pm
@@ -1,8 +1,10 @@
 package Devel::AssertOS::GNUkFreeBSD;
 
 use Devel::CheckOS;
+use strict;
+use warnings;
 
-$VERSION = '1.1';
+our $VERSION = '1.1';
 
 sub os_is { $^O =~ /^gnukfreebsd$/i ? 1 : 0; }
 

diff --git a/lib/Devel/AssertOS/HPUX.pm b/lib/Devel/AssertOS/HPUX.pm
@@ -1,8 +1,10 @@
 package Devel::AssertOS::HPUX;
 
 use Devel::CheckOS;
+use strict;
+use warnings;
 
-$VERSION = '1.2';
+our $VERSION = '1.2';
 
 sub os_is { $^O =~ /^hpux$/i ? 1 : 0; }
 

diff --git a/lib/Devel/AssertOS/Haiku.pm b/lib/Devel/AssertOS/Haiku.pm
@@ -1,8 +1,10 @@
 package Devel::AssertOS::Haiku;
 
 use Devel::CheckOS;
+use strict;
+use warnings;
 
-$VERSION = '1.1';
+our $VERSION = '1.1';
 
 sub os_is { $^O =~ /^haiku$/i ? 1 : 0; }
 

diff --git a/lib/Devel/AssertOS/Interix.pm b/lib/Devel/AssertOS/Interix.pm
@@ -1,8 +1,10 @@
 package Devel::AssertOS::Interix;
 
 use Devel::CheckOS;
+use strict;
+use warnings;
 
-$VERSION = '1.2';
+our $VERSION = '1.2';
 
 sub os_is { $^O =~ /^interix$/i ? 1 : 0; }
 

diff --git a/lib/Devel/AssertOS/Irix.pm b/lib/Devel/AssertOS/Irix.pm
@@ -1,8 +1,10 @@
 package Devel::AssertOS::Irix;
 
 use Devel::CheckOS;
+use strict;
+use warnings;
 
-$VERSION = '1.2';
+our $VERSION = '1.2';
 
 sub os_is { $^O =~ /^irix$/i ? 1 : 0; }
 

diff --git a/lib/Devel/AssertOS/Linux.pm b/lib/Devel/AssertOS/Linux.pm
@@ -1,8 +1,10 @@
 package Devel::AssertOS::Linux;
 
 use Devel::CheckOS;
+use strict;
+use warnings;
 
-$VERSION = '1.3';
+our $VERSION = '1.3';
 
 
 sub subtypes { qw(Android) }

diff --git a/lib/Devel/AssertOS/Linux/Debian.pm b/lib/Devel/AssertOS/Linux/Debian.pm
@@ -2,6 +2,7 @@ package Devel::AssertOS::Linux::Debian;
 
 use Devel::CheckOS;
 use strict;
+use warnings;
 
 our $VERSION = '1.0';
 

diff --git a/lib/Devel/AssertOS/Linux/v2_6.pm b/lib/Devel/AssertOS/Linux/v2_6.pm
@@ -3,8 +3,10 @@
 package Devel::AssertOS::Linux::v2_6;
 
 use Devel::CheckOS;
+use strict;
+use warnings;
 
-$VERSION = '1.3';
+our $VERSION = '1.3';
 
 sub os_is {
     Devel::CheckOS::os_is('Linux') &&

diff --git a/lib/Devel/AssertOS/MPEiX.pm b/lib/Devel/AssertOS/MPEiX.pm
@@ -1,8 +1,10 @@
 package Devel::AssertOS::MPEiX;
 
 use Devel::CheckOS;
+use strict;
+use warnings;
 
-$VERSION = '1.2';
+our $VERSION = '1.2';
 
 sub os_is { $^O =~ /^mpeix$/i ? 1 : 0; }
 

diff --git a/lib/Devel/AssertOS/MSDOS.pm b/lib/Devel/AssertOS/MSDOS.pm
@@ -1,8 +1,10 @@
 package Devel::AssertOS::MSDOS;
 
 use Devel::CheckOS;
+use strict;
+use warnings;
 
-$VERSION = '1.2';
+our $VERSION = '1.2';
 
 sub os_is { $^O =~ /^dos$/i ? 1 : 0; }
 

diff --git a/lib/Devel/AssertOS/MSWin32.pm b/lib/Devel/AssertOS/MSWin32.pm
@@ -1,8 +1,10 @@
 package Devel::AssertOS::MSWin32;
 
 use Devel::CheckOS;
+use strict;
+use warnings;
 
-$VERSION = '1.3';
+our $VERSION = '1.3';
 
 sub os_is { $^O =~ /^MSWin32$/i ? 1 : 0; }
 

diff --git a/lib/Devel/AssertOS/MacOSX.pm b/lib/Devel/AssertOS/MacOSX.pm
@@ -1,8 +1,10 @@
 package Devel::AssertOS::MacOSX;
 
 use Devel::CheckOS;
+use strict;
+use warnings;
 
-$VERSION = '1.2';
+our $VERSION = '1.2';
 
 sub os_is { $^O =~ /^darwin$/i ? 1 : 0; }
 

diff --git a/lib/Devel/AssertOS/MacOSX/v10_0.pm b/lib/Devel/AssertOS/MacOSX/v10_0.pm
@@ -2,6 +2,7 @@ package Devel::AssertOS::MacOSX::v10_0;
 
 use Devel::CheckOS;
 use strict;
+use warnings;
 
 our $VERSION = '1.0';
 

diff --git a/lib/Devel/AssertOS/MacOSX/v10_1.pm b/lib/Devel/AssertOS/MacOSX/v10_1.pm
@@ -2,6 +2,7 @@ package Devel::AssertOS::MacOSX::v10_1;
 
 use Devel::CheckOS;
 use strict;
+use warnings;
 
 our $VERSION = '1.0';
 

diff --git a/lib/Devel/AssertOS/MacOSX/v10_10.pm b/lib/Devel/AssertOS/MacOSX/v10_10.pm
@@ -2,6 +2,7 @@ package Devel::AssertOS::MacOSX::v10_10;
 
 use Devel::CheckOS;
 use strict;
+use warnings;
 
 our $VERSION = '1.0';
 

diff --git a/lib/Devel/AssertOS/MacOSX/v10_2.pm b/lib/Devel/AssertOS/MacOSX/v10_2.pm
@@ -2,6 +2,7 @@ package Devel::AssertOS::MacOSX::v10_2;
 
 use Devel::CheckOS;
 use strict;
+use warnings;
 
 our $VERSION = '1.0';
 

diff --git a/lib/Devel/AssertOS/MacOSX/v10_3.pm b/lib/Devel/AssertOS/MacOSX/v10_3.pm
@@ -2,6 +2,7 @@ package Devel::AssertOS::MacOSX::v10_3;
 
 use Devel::CheckOS;
 use strict;
+use warnings;
 
 our $VERSION = '1.0';
 

diff --git a/lib/Devel/AssertOS/MacOSX/v10_4.pm b/lib/Devel/AssertOS/MacOSX/v10_4.pm
@@ -4,6 +4,7 @@ package Devel::AssertOS::MacOSX::v10_4;
 
 use Devel::CheckOS;
 use strict;
+use warnings;
 
 our $VERSION = '1.4';