Debian

[daleevans]

detects debian support via lsb_release or the existence of /etc/debian_version

[DrHyde]

FYI it needed a 2>/dev/null on the invocation of lsb_release for some really old Debians, but thanks for this and all your other patches - I'll get a new release to the CPAN soon.

[daleevans]

Whoops :) I actually came across this as part of the CPAN Pull Request
Challenge (http://perlmaven.com/2015-cpan-pull-request-challenge). As
far as I can tell, there's absolutely nothing wrong with this module so
aside from adding more features, there's not a lot to do but one thing
that the project wants to do is improve Kwalitee scores. The issues
raised on this module are kind of obscure IMHO
(http://cpants.cpanauthors.org/dist/Devel-CheckOS) and I don't know if
you have any interest in them, but if you do, I'd be happy to do the
grunt work for these (taken from the Kwalitee report):

These fails do affect your Kwalitee scores. This distribution may not be
installed cleanly, or may have some issues in license or documentation.
Please consider fixing them, or tell us
https://github.com/cpants/www-cpants/issues if they are false.

metric remedy
use strict

This distribution does not 'use strict;' (or its equivalents) in all of
its modules. Note that this is not about the actual strictness of the
modules. It's bad if nobody can tell whether the modules are strictly
written or not, without reading the source code of your favorite clever
module that actually enforces strictness. In other words, it's bad if
someone feels the need to add 'use strict' to your modules.

Add 'use strict' (or its equivalents) to all modules, or convince us
that your favorite module is well-known enough and people can easily see
the modules are strictly written.

consistent version

This distribution has .pm files with inconsistent versions.

Split the distribution, or fix the version numbers to make them
consistent (use the highest version number to avoid version downgrade).

  Extra metrics

These fails affect your total Kwalitee score, but don't affect the one
for the Game. Some of them should be fixed by all means. Others are just
matters of taste.

metric remedy
meta yml declares perl version

This distribution does not declare the minimum perl version in META.yml.

If you are using Build.PL define the {requires}{perl} = VERSION field.
If you are using MakeMaker (Makefile.PL) you should upgrade
ExtUtils::MakeMaker to 6.48 and use MIN_PERL_VERSION parameter.
Perl::MinimumVersion can help you determine which version of Perl your
module needs.

meta yml has license

This distribution does not have a license defined in META.yml.

Define the license if you are using in Build.PL. If you are using
MakeMaker (Makefile.PL) you should upgrade to ExtUtils::MakeMaker
version 6.31.

use warnings

This distribution does not 'use warnings;' (or its equivalents) in all
of its modules. Note that this is not about that your modules actually
warn when something bad happens. It's bad if nobody can tell if a module
warns or not, without reading the source code of your favorite module
that actually enforces warnings. In other words, it's bad if someone
feels the need to add 'use warnings' to your modules.

Add 'use warnings' (or its equivalents) to all modules (this will
require perl > 5.6), or convince us that your favorite module is
well-known enough and people can easily see the modules warn when
something bad happens.

On 2015-03-04 2:22 PM, David Cantrell wrote:

FYI it needed a 2>/dev/null on the invocation of lsb_release for some
/really/ old Debians, but thanks for this and all your other patches -
I'll get a new release to the CPAN soon.

—
Reply to this email directly or view it on GitHub
#9 (comment).

[DrHyde]

use strict: yup, I'd accept a patch for that.

consistent version: I do not consider this to be a valid indicator of quality (or even of kwalitee)

meta yml declares perl version: patches welcome :-)

meta yml has license: I have deep objections to the META.yml licence field's existence and spec. It attempts to reduce a very complex issue down to a multiple choice quiz.

use warnings: patches welcome again