Be able to validate Denmark's mobile numbers #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, I'll keep an eye on this - Google are tracking it as https://issuetracker.google.com/issues/331311053 |
waterkip
force-pushed
the
denmark-distinction-ready
branch
from
e37023c
to
d07e7f0
Compare
Our app has an issue with Danish numbers, which cannot be validated as either fixed line or mobile. This is a minor inconvenience to our users. The problem is that upstream has fixed lines and mobiles lines defined as the same regexp and Number::Phone strips the checks for is_mobile and is_fixed when these are the same, as found in build-data.stubs and build-tests.pl, introduced by 02f12d4. I've created an upstream PR to improve the Danish number checks so we in Perl are going to be aware what Denmark's mobile and landline number are. I've ran build-data.sh --force with the data from the PR at Google and the tests in t/stubs.t work as intended. Only merge after google/libphonenumber#3417 has been merged into the Google code base. Google fixed it a weebit different from how I did it in commit f64bace16b9319c5eedfaa5723c1b60d72cc5311. Signed-off-by: Wesley Schwengle <waterkip@cpan.org>
waterkip
force-pushed
the
denmark-distinction-ready
branch
from
d07e7f0
to
0edc011
Compare
|
Google has made updates available, which includes metadata changes for Denmark: google/libphonenumber@f64bace I've ran |
|
Thanks, looks good. I'll include this in the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our app has an issue with Danish numbers, which cannot be validated as either fixed line or mobile. This is a minor inconvenience to our users.
The problem is that upstream has fixed lines and mobiles lines defined as the same regexp and Number::Phone strips the checks for is_mobile and is_fixed when these are the same, as found in build-data.stubs and build-tests.pl, introduced by 02f12d4.
I've created an upstream PR to improve the Danish number checks so we in Perl are going to be aware what Denmark's mobile and landline number are. I've ran build-data.sh --force with the data from the PR at Google and the tests in t/stubs.t work as intended.
Only merge after google/libphonenumber#3417 has been merged into the Google code base.