-
Notifications
You must be signed in to change notification settings - Fork 7.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improved accessibility of telegram for blind users #1541
improved accessibility of telegram for blind users #1541
Conversation
Yes, it is necessary. |
It is very importent for screanreader users of telegram. I am waiting for merging this pull request very much! |
I join for pull request. It is very importent for blind users! |
@DrKLO does not accept pull request |
@armef97 why? |
@AlexandrKozlovskiy why do you ask me? Do you understand that this is a mirror repo? He does not care less of what we think, issues are not even open. He simply push sometimes his code here, just to say that telegram is opensource. If you spend your time to push a pull request here, you are wasting your time, it will never be merged. |
So how did these features got implemented later? #1530 🤔 |
You see it branched? I don't think so. Maybe he just browse here sometimes to copy pr's code |
8144a82
to
3173696
Compare
Merged some parts of DrKLO/Telegram#1541 Former-commit-id: b3cff3aa2b066692aaccc453f422e4cff83e234e
In oficial telegram for android it exists problem,when it impossible accept or decline calls with talkback,if we have android seven or lower,I.E when blind users do double tap,it nothing happends,because we not get action AccessibilityNodeInfo.ACTION_CLICK in method of custom view performAccessibilityAction and in method onTouchEvent of custom view we should be use super version of this method,I.E super.onTouchEvent and we should set clickable true in constructor of class CallSwipeView. Also in telegram,when someone busy and decline our call,instead of contentDescription with CallAgain string name we have contentDescription with VoipEndCall string name,so blind users consider,that after pressing of this button window of call in telegram probably will be closed,I.E as it works,when user press cancel button,but instead of this call start again,so it should be fixed,because it misleadin of blind users of telegram. Also in this pull request was fixed error 87,which happends,for example,if we compile telegram in android studio in windows.