Fixed issue #125 - push notifications do not always work #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem is that the code which sends the request to the GCM is inside an AsyncTask and since Froyo tasks are run serially, so if another task starts before it and doesn't finish it doesn't run. The fix is to use the new API of executeOnExecutor which runs the task in parallel to other tasks.
DrKLO
pushed a commit
that referenced
this pull request
May 16, 2014
|
thanks, in 5ebe60a |
|
Cool, but I see that you don't check that the API version >= 11 before using the new api. Didn't it give you a compilation error that this is a new api (I see that the minimum SDK version is still 8)? |
|
@ShaiBer didn't notice that, fixed. It's not give compilation error, but it will crash on 2.x devices. |
hav3n
pushed a commit
to hav3n/Telegram
that referenced
this pull request
Jun 18, 2014
panahit
pushed a commit
to panahit/Telegramma
that referenced
this pull request
Mar 10, 2016
hrzhu
pushed a commit
to hrzhu/Telegram
that referenced
this pull request
Jul 11, 2017
nekohasekai
pushed a commit
to NekogramX-Backup/NekoX
that referenced
this pull request
Mar 26, 2020
… bug fixes DrKLO/Telegram#418 Former-commit-id: a1a639fc8503d6aa51896dfb4912072ad12ae678
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem is that the code which sends the request to the GCM is inside an AsyncTask and since Froyo tasks are run serially, so if another task starts before it and doesn't finish it doesn't run.
The fix is to use the new API of executeOnExecutor which runs the task in parallel to other tasks.