Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE]: Pull hyperparameters out of the code #5

Open
DrKwint opened this issue Apr 12, 2022 · 3 comments · May be fixed by #3 or #8
Open

[FEATURE]: Pull hyperparameters out of the code #5

DrKwint opened this issue Apr 12, 2022 · 3 comments · May be fixed by #3 or #8
Assignees
Labels
enhancement New feature or request

Comments

@DrKwint
Copy link
Owner

DrKwint commented Apr 12, 2022

Is your feature request related to a problem? Please describe.
We want to tune the hyperparameters from the values we inherited from other settings

Describe the solution you'd like
Remove hyperparameters to be arguments and/or gin configuration so we can tune them

@DrKwint DrKwint added the enhancement New feature or request label Apr 12, 2022
@evan-palmer evan-palmer linked a pull request Apr 13, 2022 that will close this issue
@evan-palmer evan-palmer self-assigned this Apr 13, 2022
@evan-palmer
Copy link
Collaborator

I am starting by pulling the hyperparameters out as I refactor and cleanup the implementation. My plan is to make most of them configurable.

One parameter that I am considering integrating is an epsilon decay function for the __train_step. What do you think @DrKwint ?

@DrKwint DrKwint linked a pull request Apr 13, 2022 that will close this issue
@DrKwint
Copy link
Owner Author

DrKwint commented Apr 13, 2022

You can see the changes I've made relevant to this issue on the PR. Sorry I didn't communicate better, I got excited.

@evan-palmer
Copy link
Collaborator

No problem! These look similar to the changes that I have made as well, so it won't be hard to merge these

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants