tests: create better test for Pool.run() asynchronocity; refactor mai…

…n code slightly, same behavior, tests pass.
DrPaulBrewer · May 24, 2016 · ac26fdf · ac26fdf
1 parent 3e38c97
commit ac26fdf
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/index.js b/index.js
@@ -254,7 +254,10 @@ Pool.prototype.run = function(untilTime, done, batch){
 	    return (nextAgent && (nextAgent.wakeTime < untilTime));
 	},
 	function(cb){
-	    async.setImmediate(function(){ that.syncRun(untilTime, batch || 1); cb(false); });
+	    async.setImmediate(function(){
+		that.syncRun(untilTime, batch || 1);
+		cb();
+	    });
 	},
 	function(e,d){
 	    done.call(that,e);

diff --git a/test/index.js b/test/index.js
@@ -570,6 +570,8 @@ describe('new Pool', function(){
 		done();
 	    };
 	    myPool.run(1000, cb, 53);
+	    /* previous line should return immediately, before event loop runs, so wakeCounts are zero */
+	    wakes.forEach(function(wakeCount, i){ wakeCount.should.equal(0); });
 	} else {
 	    myPool.syncRun(1000);
 	    checkWakes();