Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Storage Manager #44

Merged
merged 1 commit into from
Jan 7, 2021

Conversation

sairam4123
Copy link
Contributor

Adds storage manager

Supersedes #41

godotcord_storage_manager.cpp Outdated Show resolved Hide resolved
Copy link
Owner

@Drachenfrucht1 Drachenfrucht1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should decide if we want to take the signal approach or callback approach for async functions to be consistent across the whole project.

godotcord_storage_manager.cpp Outdated Show resolved Hide resolved
godotcord_storage_manager.cpp Outdated Show resolved Hide resolved
godotcord_storage_manager.cpp Outdated Show resolved Hide resolved
godotcord_storage_manager.cpp Outdated Show resolved Hide resolved
godotcord_storage_manager.cpp Outdated Show resolved Hide resolved
godotcord_storage_manager.cpp Outdated Show resolved Hide resolved
@jordigcs
Copy link
Contributor

jordigcs commented Jan 6, 2021

We should decide if we want to take the signal approach or callback approach for async functions to be consistent across the whole project.

I think signals would be the most flexible. You get yields, connections, and more.

@sairam4123
Copy link
Contributor Author

sairam4123 commented Jan 6, 2021

I'll squash all the commits, once each and every issue is fixed.

@sairam4123
Copy link
Contributor Author

We should decide if we want to take the signal approach or callback approach for async functions to be consistent across the whole project.

I think signals would be the most flexible. You get yields, connections, and more.

That's why, I've chosen Signals approach.

godotcord_storage_manager.cpp Outdated Show resolved Hide resolved
godotcord_storage_manager.cpp Show resolved Hide resolved
@sairam4123
Copy link
Contributor Author

I will squash all commits into one now.

@Drachenfrucht1 Drachenfrucht1 merged commit c1b63e1 into Drachenfrucht1:master Jan 7, 2021
@sairam4123 sairam4123 deleted the storage-manager branch January 7, 2021 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants