Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt test case for glue:R0036 to replacement requirement glue:R0036_0 #17

Merged
merged 18 commits into from
Nov 8, 2022
Merged

Adapt test case for glue:R0036 to replacement requirement glue:R0036_0 #17

merged 18 commits into from
Nov 8, 2022

Conversation

ben-Draeger
Copy link
Collaborator

@ben-Draeger ben-Draeger commented Oct 25, 2022 •
edited by maximilianpilz

Requirement Glue:R0036 has been replaced. Hence the test case needed to be adapted.

Checklist

The following aspects have been respected by the author of this pull request, confirmed by both pull request assignee and reviewer:

  • Adherence to coding conventions
    • Pull Request Assignee
    • Reviewer
  • Adherence to javadoc conventions
    • Pull Request Assignee
    • Reviewer
  • Changelog update (necessity checked and entry added or not added respectively)
    • Pull Request Assignee
    • Reviewer
  • README update (necessity checked and entry added or not added respectively)
    • Pull Request Assignee
    • Reviewer
  • SDCcc executable ran against a test device (if necessary)
    • Pull Request Assignee
    • Reviewer

@ben-Draeger ben-Draeger requested review from ldeichmann and maximilianpilz and removed request for ldeichmann October 25, 2022 15:26
@maximilianpilz maximilianpilz mentioned this pull request Nov 3, 2022
Merged
12 tasks
maximilianpilz
maximilianpilz requested changes Nov 4, 2022
View reviewed changes
Copy link
Collaborator

@maximilianpilz maximilianpilz left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

running the DirectSubscriptionHandlingTest in the TestSuite.main results in the following error:

[Guice/MissingImplementation]: No implementation for CommunicationLog was bound.

please fix it

maximilianpilz
maximilianpilz requested changes Nov 4, 2022
View reviewed changes
Copy link
Collaborator

@maximilianpilz maximilianpilz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now the unittest uses CommunicationLogDummyImpl and the TestSuite CommunicationLogImpl.

let both use CommunicationLogImpl

@ben-Draeger
Copy link
Collaborator Author

running the DirectSubscriptionHandlingTest in the TestSuite.main results in the following error:

[Guice/MissingImplementation]: No implementation for CommunicationLog was bound.

please fix it

Done.

@ben-Draeger
Copy link
Collaborator Author

Now the unittest uses CommunicationLogDummyImpl and the TestSuite CommunicationLogImpl.

let both use CommunicationLogImpl

Done.

maximilianpilz
maximilianpilz previously approved these changes Nov 8, 2022
View reviewed changes
@maximilianpilz maximilianpilz dismissed their stale review November 8, 2022 14:35

Checklist not fulfilled

@maximilianpilz
Copy link
Collaborator

README.md has to be updated, because there is one occurrence of R0036 there

@ben-Draeger
Copy link
Collaborator Author

README.md has to be updated, because there is one occurrence of R0036 there

Done.

@maximilianpilz maximilianpilz changed the title Adapted test case for glue:R0036 to replacement requirement glue:R0036_0 Adapt test case for glue:R0036 to replacement requirement glue:R0036_0 Nov 8, 2022
@maximilianpilz maximilianpilz merged commit 0292d4a into Draegerwerk:main Nov 8, 2022
@maximilianpilz maximilianpilz mentioned this pull request Nov 8, 2022
Closed
maximilianpilz added a commit that referenced this pull request Nov 8, 2022
@maximilianpilz
Revert "Adapt test case for glue:R0036 to replacement requirement glu…
a4ace2a 
…e:R0036_0 (#17)"

This reverts commit 0292d4a.
@maximilianpilz maximilianpilz mentioned this pull request Nov 8, 2022
Merged
maximilianpilz added a commit that referenced this pull request Nov 9, 2022
@maximilianpilz
Revert "Adapt test case for glue:R0036 to replacement requirement glu…
91487ab 
…e:R0036_0" (#32)

Reverts #17

Reason is that R0036_0 is broken on main now and the implementation can
not work conceptionally i.e. it requires full refactoring.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maximilianpilz maximilianpilz maximilianpilz approved these changes

Assignees

@ben-Draeger ben-Draeger

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ben-Draeger @maximilianpilz