Removed useless setters #69

DraftBot-A-Discord-Adventure · Aug 8, 2020 · edc2b18 · edc2b18
1 parent d690939
commit edc2b18
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 18 deletions.
diff --git a/src/commands/admin/ChangePointsCommand.js b/src/commands/admin/ChangePointsCommand.js
@@ -14,7 +14,7 @@ const ChangePointsCommand = async function(language, message, args) {
   let entity;
   const playerId = message.mentions.users.last().id;
   [entity] = await Entities.getOrRegister(playerId);
-  await entity.Player.setPoints(args[1]);
+  entity.Player.score = parseInt(args[1]);
   await entity.Player.save();
 
   embed.setColor(JsonReader.bot.embed.default)

diff --git a/src/commands/admin/ChangePointsWeekCommand.js b/src/commands/admin/ChangePointsWeekCommand.js
@@ -14,7 +14,7 @@ const ChangePointsWeekCommand = async function(language, message, args) {
   let entity;
   const playerId = message.mentions.users.last().id;
   [entity] = await Entities.getOrRegister(playerId);
-  await entity.Player.setPointsWeek(args[1]);
+  entity.Player.weeklyScore = parseInt(args[1]);
   await entity.Player.save();
 
   embed.setColor(JsonReader.bot.embed.default)

diff --git a/src/core/models/Players.js b/src/core/models/Players.js
@@ -92,22 +92,6 @@ module.exports = (Sequelize, DataTypes) => {
         .includes(badge);
   };
 
-  /**
-   * @param {("points")} points - A number representating the score
-   * @deprecated 2.1.0 Directly use score attribute from entity
-   */
-  Players.prototype.setPoints = function(points) {
-    this.score = points;
-  };
-
-  /**
-   * @param {("pointsWeek")} pointsWeek - A number representating the weekly score
-   * @deprecated 2.1.0 Directly use weeklyScore attribute from entity
-   */
-  Players.prototype.setPointsWeek = function(points) {
-    this.weeklyScore = points;
-  };
-
   Players.beforeSave((instance, options) => {
     instance.setDataValue('updatedAt',
         require('moment')().format('YYYY-MM-DD HH:mm:ss'));