Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refact command petfeed #473

Closed
eagles666 opened this issue Jun 22, 2021 · 3 comments · Fixed by #504
Closed

refact command petfeed #473

eagles666 opened this issue Jun 22, 2021 · 3 comments · Fixed by #504
Assignees
@eagles666
Labels
bug Something isn't working refactoring No visible changes but code improved
Milestone
2.2.1

Comments

@eagles666
Copy link
Contributor

je suis un boulet :/
@eagles666 eagles666 added the bug Something isn't working label Jun 22, 2021
@eagles666 eagles666 self-assigned this Jun 22, 2021
@eagles666 eagles666 added this to the 2.2.1 milestone Jun 22, 2021
@eagles666 eagles666 changed the title le petfeed n'augmente pas les points d'amour du familier quand pas de guilde refact command petfeed Jun 22, 2021
@eagles666
Copy link
Contributor Author

ce qui se passe c'est que tout le code correspond à ma version que j'avait coder avant que draft demande de rajouter une partie pour les gens qui ont pas de guilde... j'ai rajouter cette partie par dessus, mais du coup y'as rien qui vas

@romain22222 romain22222 added the refactoring No visible changes but code improved label Jun 27, 2021
@BastLast
Copy link
Member

BastLast commented Jul 2, 2021

@eagles666 possible d'avoir des indications sur quoi faire ici parce que j'avoue que j'ai pas compris mdr

@eagles666
Copy link
Contributor Author

  • ligne 1 : retirer cette ligne
  • certains commentaires sont en français
  • ajouter
pet.lovePoints += JsonReader.food.commonFood.effect;

à la ligne 157

  • la partie qui concerne les gens qui n'ont pas de guilde est directement dans la commande
  • certaines parties pourraient être simplifiées

BastLast added a commit that referenced this issue Jul 17, 2021
@BastLast
bugfix petfeed #473
f1a4868
@BastLast BastLast linked a pull request Jul 17, 2021 that will close this issue
Petfeedfix #504
Merged
BastLast added a commit that referenced this issue Jul 17, 2021
@BastLast
bugfix petfeed #473
9b80767
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eagles666 eagles666

Labels
bug Something isn't working refactoring No visible changes but code improved
Projects
None yet
Milestone
2.2.1
Development

Successfully merging a pull request may close this issue.

Petfeedfix DraftBot-A-Discord-Adventure/DraftBot
3 participants
@romain22222 @BastLast @eagles666