New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VIES_EU_COUNTRY_LIST Visibility #120

Closed

blaaat opened this issue Nov 14, 2020 · 1 comment

blaaat commented Nov 14, 2020 •

edited

Loading

VIES_EU_COUNTRY_LIST is a protected const, but all other code is using self::VIES_EU_COUNTRY_LIST.

the protected visibility gives the illusion you can extend the class and for example remove UK (#98 ), but this wouldn't work.

VIES_EU_COUNTRY_LIST should either be private or beter; other methods should use: static::VIES_EU_COUNTRY_LIST

The text was updated successfully, but these errors were encountered:

blaaat added a commit to blaaat/vies that referenced this issue


          DragonBe#120 use late static binding

a896364

blaaat mentioned this issue

#120 use late static binding #121

Closed

Owner

DragonBe commented Jan 12, 2021

Not going to make them static

DragonBe closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment