Uncaught SoapFault exceptions

[jonathanmaron]

On iterating through a long list (ca. 2,000 items) of VAT numbers, validating each, I have received all the following uncaught SoapFault exceptions.

PHP Fatal error: Uncaught SoapFault exception: [soap:Server] MS_MAX_CONCURRENT_REQ
in [..]/vies/src/Vies/Vies.php:229

PHP Fatal error: Uncaught SoapFault exception: [soap:Server] GLOBAL_MAX_CONCURRENT_REQ
in [..]/vies/src/Vies/Vies.php:229

PHP Fatal error: Uncaught SoapFault exception: [soap:Server] MS_UNAVAILABLE
in [..]/vies/src/Vies/Vies.php:229

[DragonBe]

Thank you for reporting this failure.

Yes, there's a limit on requests you can do on the soap service but it's not documented how many request can be made in what time period.

Let me see what I can do about it.

[jonathanmaron]

I was actually more concerned that an uncaught SoapFault is thrown. Surely, the SoapFault should be caught by DragonBe\Vies\Vies, and a DragonBe\Vies\ViesException should be thrown?

I would have thought it is easier for the end user to try and catch only one specific exception in his/her application logic, than for a DragonBe\Vies\ViesException and a SoapFault.

Or am I the only one who would implement it that way?

What do you think?

[DragonBe]

@jonathanmaron You're absolutely right. Well, the issue is created and marked as bug. If I can free up some time, I will fix it in the upcoming days.

[jonathanmaron]

Fixed in #18

[jonathanmaron]

To differentiate between exceptions caused by local code, and those from the back-end service VIES, it make sense to have two exceptions. The new example "examples/checkVatBatch.php" shows why this is important.