Validators in seperate classes #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DragonBe could You enable codeclimate PR intergration .. so I can fix problems before You merge it ? |
|
Don't know why .. but lately more and more test fail because of composer issues .. 👎 |
Merged
krzaczek
changed the title
|
@DragonBe All is done ... :) |
This was referenced Jun 28, 2015
Closed
|
Woot! We're now top quality with SensioLabsInsights, CodeShip, CodeClimate and Travis-CI. Thanks a bunch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @DragonBe,
I did not like the way it was done ... 800 lines of code in one file (Validator.php) .... so ...
Every country is in a seperate class ValidatorXX. I've added information about the algo used to calculate the checksum at the top of every class. All test pass, all files have 100% code coverage.
The work is done based on http://85.81.229.78/systems/DKVIES/-%20Arkiv/Algoritme%E6ndringer/VIES-VAT%20Validation%20Routines-v15.0.doc
There is still work to do ... I was not able to find a valid French new style VAT number ... so the algo is not done yet.
Please review the code and let me know what You think of it.
Pawel