Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #54 for version 1.x #56

Merged
merged 1 commit into from
Oct 25, 2018
Merged

Conversation

krzaczek
Copy link
Collaborator

Fixes issue #54 for version 1.x of the library

@krzaczek
Copy link
Collaborator Author

krzaczek commented Oct 25, 2018

Since >=1.0.6 does not support PHP 5.6 You can still make it work. If using composer package manager You can set this library to version 1.0.6 and then use this https://github.com/cweagans/composer-patches to automatically apply this patch when running composer install adding this url https://patch-diff.githubusercontent.com/raw/DragonBe/vies/pull/56.diff as a patch source

Copy link
Owner

@DragonBe DragonBe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for porting it back to 1.0

@DragonBe DragonBe merged commit f77c228 into DragonBe:1.0 Oct 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants