Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devel/boost-libs: uncriple the boost-libs #690

Merged
merged 1 commit into from
Dec 16, 2016

Conversation

zrj-rimwis
Copy link
Contributor

@zrj-rimwis zrj-rimwis commented Dec 16, 2016

Maybe it would be better if was done on freebsd-ports side, dunno but:

Must use at least -std=c++11 while compiling the libs (partially wrong abi)
boost headers has no safe-guards when compiled w/ -std=c++98, while most of
packages rely on -std=c++11 while using these boost headers.
Explains why certain things doesn't seem right here and there.

@@ -291,19 +301,19 @@ Performing configuration checks
- sparc : no
- x86 : yes
- symlinks supported : yes
- - C++11 mutex : no
+ - C++11 mutex : yes
- lockfree boost::atomic_flag : yes
- - Boost.Config Feature Check: cxx11_auto_declarations : no
- - Boost.Config Feature Check: cxx11_constexpr : no
- - Boost.Config Feature Check: cxx11_defaulted_functions : no
+ - Boost.Config Feature Check: cxx11_auto_declarations : yes
+ - Boost.Config Feature Check: cxx11_constexpr : yes
+ - Boost.Config Feature Check: cxx11_defaulted_functions : yes
- Boost.Config Feature Check: cxx11_final : yes
- - Boost.Config Feature Check: cxx11_hdr_tuple : no
- - Boost.Config Feature Check: cxx11_lambdas : no
- - Boost.Config Feature Check: cxx11_noexcept : no
- - Boost.Config Feature Check: cxx11_nullptr : no
- - Boost.Config Feature Check: cxx11_rvalue_references : no
- - Boost.Config Feature Check: cxx11_template_aliases : no
- - Boost.Config Feature Check: cxx11_thread_local : no
+ - Boost.Config Feature Check: cxx11_hdr_tuple : yes
+ - Boost.Config Feature Check: cxx11_lambdas : yes
+ - Boost.Config Feature Check: cxx11_noexcept : yes
+ - Boost.Config Feature Check: cxx11_nullptr : yes
+ - Boost.Config Feature Check: cxx11_rvalue_references : yes
+ - Boost.Config Feature Check: cxx11_template_aliases : yes
+ - Boost.Config Feature Check: cxx11_thread_local : yes
- Boost.Config Feature Check: cxx11_variadic_templates : yes
- has_icu builds : yes

Must use at least -std=c++11 while compiling the libs (partially wrong abi)
boost headers has no safe-guards when compiled w/ -std=c++98, while most of
packages rely on -std=c++11 while using these boost headers.
Explains why certain things doesn't seem right here and there.

 @@ -291,19 +301,19 @@ Performing configuration checks
      - sparc                    : no
      - x86                      : yes
      - symlinks supported       : yes
 -    - C++11 mutex              : no
 +    - C++11 mutex              : yes
      - lockfree boost::atomic_flag : yes
 -    - Boost.Config Feature Check: cxx11_auto_declarations : no
 -    - Boost.Config Feature Check: cxx11_constexpr : no
 -    - Boost.Config Feature Check: cxx11_defaulted_functions : no
 +    - Boost.Config Feature Check: cxx11_auto_declarations : yes
 +    - Boost.Config Feature Check: cxx11_constexpr : yes
 +    - Boost.Config Feature Check: cxx11_defaulted_functions : yes
      - Boost.Config Feature Check: cxx11_final : yes
 -    - Boost.Config Feature Check: cxx11_hdr_tuple : no
 -    - Boost.Config Feature Check: cxx11_lambdas : no
 -    - Boost.Config Feature Check: cxx11_noexcept : no
 -    - Boost.Config Feature Check: cxx11_nullptr : no
 -    - Boost.Config Feature Check: cxx11_rvalue_references : no
 -    - Boost.Config Feature Check: cxx11_template_aliases : no
 -    - Boost.Config Feature Check: cxx11_thread_local : no
 +    - Boost.Config Feature Check: cxx11_hdr_tuple : yes
 +    - Boost.Config Feature Check: cxx11_lambdas : yes
 +    - Boost.Config Feature Check: cxx11_noexcept : yes
 +    - Boost.Config Feature Check: cxx11_nullptr : yes
 +    - Boost.Config Feature Check: cxx11_rvalue_references : yes
 +    - Boost.Config Feature Check: cxx11_template_aliases : yes
 +    - Boost.Config Feature Check: cxx11_thread_local : yes
      - Boost.Config Feature Check: cxx11_variadic_templates : yes
      - has_icu builds           : yes
@jrmarino jrmarino merged commit 0c2f643 into DragonFlyBSD:master Dec 16, 2016
@zrj-rimwis zrj-rimwis deleted the d1612_fix_boost4 branch December 16, 2016 18:49
uqs pushed a commit to freebsd/freebsd-ports that referenced this pull request Sep 25, 2017
PR:		218835
Obtained from:	DragonFlyBSD/DeltaPorts#690
Approved by:	maintainer timeout (2 months)
Exp-run by:	antoine
Differential Revision:	https://reviews.freebsd.org/D11582


git-svn-id: svn+ssh://svn.freebsd.org/ports/head@450557 35697150-7ecd-e111-bb59-0022644237b5
uqs pushed a commit to freebsd/freebsd-ports that referenced this pull request Sep 25, 2017
PR:		218835
Obtained from:	DragonFlyBSD/DeltaPorts#690
Approved by:	maintainer timeout (2 months)
Exp-run by:	antoine
Differential Revision:	https://reviews.freebsd.org/D11582
@jbeich
Copy link

jbeich commented Jul 13, 2018

FWIW, Boost 1.68 update will bump to C++14 in order to avoid boostorg/system#24

@jef
Copy link

jef commented Nov 6, 2018

it hasn't been bumped to C++14

svmhdvn pushed a commit to svmhdvn/freebsd-ports that referenced this pull request Jan 10, 2024
PR:		218835
Obtained from:	DragonFlyBSD/DeltaPorts#690
Approved by:	maintainer timeout (2 months)
Exp-run by:	antoine
Differential Revision:	https://reviews.freebsd.org/D11582
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants