Fix shm permission problem of rspamd on DragonFly #727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rspamd tried to call shm_open(3) with a path in the root filesystem
(e.g. /rhm.3f0fd440d46fac91e1b4). Obviously, this fails due to wrong
permissions, and in effect this makes rspamd very slow and probably it
cannot perform it's job (spam filtering) at all.
Lots of lines like the following were found in
/var/log/rspamd/rspamd.log before this patch:
rspamd_shmem_mkstemp: /usr/obj/dports/mail/rspamd/rspamd-1.4.1/src
/libutil/util.c:1970: failed to create temp shmem
/rhm.3f0fd440d46fac91e1b4: Permission denied
This patch fixes the problem by creating the shm files in /tmp. With
this patch applied, these lines are gone from the log.
vstakhov
pushed a commit
to rspamd/rspamd
that referenced
this pull request
Jan 6, 2017
Rspamd tried to call shm_open(3) with a path in the root filesystem
(e.g. /rhm.3f0fd440d46fac91e1b4). But DragonFly uses regular files
for shm. Obviously, this fails, because rspamd has no permissions
to create files in the root (/).
Lots of lines like the following were found in
/var/log/rspamd/rspamd.log before this patch:
rspamd_shmem_mkstemp: /usr/obj/dports/mail/rspamd/rspamd-1.4.1/src
/libutil/util.c:1970: failed to create temp shmem
/rhm.3f0fd440d46fac91e1b4: Permission denied
Also, rspamd made the receiving of mail very slow, when used
in the pre-accept rmilter setting, due to these errors. Even
worse, it just didn't filter emails at all.
This patch fixes the problem by creating the shm files in /tmp
for DragonFly. With this patch applied, these lines are gone from
the log and emails now correctly contain the X-Spamd-Result header,
AND receiving mails is now much much faster.
For rspamd 1.4.1, we will fix it in dports:
DragonFlyBSD/DeltaPorts#727
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rspamd tried to call shm_open(3) with a path in the root filesystem
(e.g. /rhm.3f0fd440d46fac91e1b4). Obviously, this fails due to wrong
permissions, and in effect this makes rspamd very slow and probably it
cannot perform it's job (spam filtering) at all.
Lots of lines like the following were found in
/var/log/rspamd/rspamd.log before this patch:
This patch fixes the problem by creating the shm files in /tmp. With
this patch applied, these lines are gone from the log.