-
-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
添加pread&pwrite #528
Merged
fslongjin
merged 16 commits into
DragonOS-Community:master
from
yuyi2439:patch-pread&pwrite
Feb 19, 2024
Merged
添加pread&pwrite #528
fslongjin
merged 16 commits into
DragonOS-Community:master
from
yuyi2439:patch-pread&pwrite
Feb 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fslongjin
requested changes
Feb 19, 2024
kernel/src/filesystem/vfs/file.rs
Outdated
len: usize, | ||
buf: &mut [u8], | ||
) -> Result<usize, SystemError> { | ||
self.readable()?; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里面的逻辑可以抽象成fn do_read(...., update_offset: bool)
函数,然后read和pread都调用这个. write同理。这样减少冗余代码。
fslongjin
approved these changes
Feb 19, 2024
Chiichen
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SYS_FCHOWN和SYS_FSYNC我觉得暂时实现不了,就没弄