Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg_* tools repo stack is broken #23

Open
xzhayon opened this issue Nov 4, 2012 · 1 comment
Open

pkg_* tools repo stack is broken #23

xzhayon opened this issue Nov 4, 2012 · 1 comment

Comments

@xzhayon
Copy link
Contributor

xzhayon commented Nov 4, 2012

pkg.info(repo=True) doesn't work with pkg_* tools, so the whole repo stack isn't even started. Additionally, pkg.add(repo=True) calls pkg_add -r $pkgname, but pkg_add -r needs LATEST_LINK. The former can be fixed making the Repo stage return True when using pkg_* (an abstract method should be created for this, like pkg.exists() or similar), the latter by using the RepoFetch stage.

This is not high priority, in my opinion.
@xzhayon
Copy link
Contributor Author

xzhayon commented Nov 5, 2012

I see that env.flags["pkg_mgmt"] is already used in another place inside repo.py (twice, with my RepoFetch patch), so I now believe that an abstract method is too much when a simple if is enough (I've experimented it with the work on RepoFetch).
Both the fixes are ready to be submitted.

xzhayon pushed a commit to xzhayon/portbuilder that referenced this issue Nov 5, 2012
Allow the pkg_* repo stack to start working
0771815 
pkg_* tools have no idea of remote repository, avoid checking if the
package is available; pkg.fetch() will fail, if it is not.

This commit fixes DragonSA#23.
xzhayon pushed a commit to xzhayon/portbuilder that referenced this issue Nov 5, 2012
Allow the pkg_* repo stack to start working
b2c08e2 
pkg_* tools have no idea of remote repository, avoid checking if the
package is available; pkg.fetch() will fail, if it is not.

This commit fixes DragonSA#23.
xzhayon pushed a commit to xzhayon/portbuilder that referenced this issue Nov 5, 2012
Beautify conditional
d044113 
This commit references DragonSA#23.
xzhayon pushed a commit to xzhayon/portbuilder that referenced this issue Nov 5, 2012
RepoConf: return true on failure only with pkg_*
1e24124 
With pkgng, instead, it's better to trash the package if we're not
sure it's OK.

This commit references DragonSA#23.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@xzhayon