Skip to content

Commit

Permalink
set publish_error_if_necessary default value at True
Browse files Browse the repository at this point in the history
  • Loading branch information
Guillaume De Saint Martin committed Sep 29, 2020
1 parent efc2223 commit b04e771
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion octobot_commons/async_job.py
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,7 @@ def _handle_run_exception(self, exception, error_on_single_failure):
else:
self.logger.debug(error_message)
# always at least print stacktrace in logs
self.logger.exception(exception)
self.logger.exception(exception, False)

def _should_run_job(self, force=False, ignore_dependencies=False):
"""
Expand Down
2 changes: 1 addition & 1 deletion octobot_commons/logging/logging_util.py
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ def error(self, message) -> None:
self._publish_log_if_necessary(message, logging.ERROR)

def exception(
self, exception, publish_error_if_necessary=False, error_message=None
self, exception, publish_error_if_necessary=True, error_message=None
) -> None:
"""
Called for an exception log
Expand Down

0 comments on commit b04e771

Please sign in to comment.