Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Binance] Add adjustForTimeDifference option #544

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions Trading/Exchange/binance/binance_exchange.py
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,15 @@ class Binance(exchanges.SpotCCXTExchange):

BINANCE_MARK_PRICE = "markPrice"

BINANCE_CCXT_OPTIONS = {
"timeDifference": 0, # the difference between system clock and Binance clock
"adjustForTimeDifference": False, # controls the adjustment logic upon instantiation
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if this fixes the invalidNonce error, that would be amazing 🎉

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope so!

}

def __init__(self, config, exchange_manager):
super().__init__(config, exchange_manager)
self.connector.add_options(self.BINANCE_CCXT_OPTIONS)

@classmethod
def get_name(cls):
return 'binance'
Expand Down