Skip to content

Commit

Permalink
fix order state on_order_refresh_successful on cleared order
Browse files Browse the repository at this point in the history
  • Loading branch information
Guillaume De Saint Martin committed Oct 26, 2020
1 parent b44673d commit ba630ba
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
3 changes: 2 additions & 1 deletion octobot_trading/personal_data/orders/order_state.py
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,8 @@ def get_logger(self):
"""
:return: the order logger
"""
return logging.get_logger(self.order.get_logger_name())
return logging.get_logger(self.order.get_logger_name() if self.order is not None else
f"{self.__class__.__name__}_without_order")

def log_order_event_message(self, state_message):
"""
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,9 @@ async def on_order_refresh_successful(self):
"""
# skip refresh process if the current order state is not the same as the one triggering this
# on_order_refresh_successful to avoid synchronization issues (state already got refreshed by another mean)
if self.state is self.order.state.state:
if self.order is None:
self.get_logger().warning(f"on_order_refresh_successful triggered on cleared order: ignoring update.")
elif self.state is self.order.state.state:
if self.order.status is enums.OrderStatus.OPEN:
self.state = enums.OrderStates.OPEN
await self.update()
Expand Down

0 comments on commit ba630ba

Please sign in to comment.