Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get the standings for the stage #69

Closed
enchantinggg4 opened this issue Mar 8, 2021 · 7 comments
Closed

Get the standings for the stage #69

enchantinggg4 opened this issue Mar 8, 2021 · 7 comments
Labels
enhancement New feature or request

Comments

@enchantinggg4
Copy link

I mean something like
manager.get.standings() will return ordered list with participants, where index is current position.
Not sure what is position in opponent object though

@Drarig29 Drarig29 added the enhancement New feature or request label Mar 8, 2021
@Drarig29 Drarig29 changed the title Any thoughts about returning standings? Get the standings for the stage Mar 8, 2021
@Drarig29
Copy link
Owner

Drarig29 commented Mar 8, 2021

Good idea.

The position isn't the thing you want. It denotes the position the opponent comes from in the previous match. Anyway. 😅

I'll add this, yeah. You will be able to get the standings for a stage: manager.get.standings(stageId: number).

@enchantinggg4
Copy link
Author

Thanks!
Recently we had a tournament, and we used your solution for backend(brackets-manager) and for frontend(brackets-viewer)
Here is the bracket :)
Thanks for your efforts.
https://dota2classic.ru/tournament/41/bracket

@Drarig29
Copy link
Owner

Drarig29 commented Mar 8, 2021

Very nice! I must say I like the theme and I tried to replicate it here.

@enchantinggg4
Copy link
Author

Bracket view is very raw, no horizontal scrolling and etc, but yeah, i like theme too, thanks

@Drarig29
Copy link
Owner

Drarig29 commented Mar 8, 2021

Yeah, I saw that 🙄

Drarig29/brackets-viewer.js#40

@qlaffont
Copy link

@enchantinggg4 you can fix it with this :

.bracket-viewer {
  overflow-x: scroll;
  width: 100%;
}

@enchantinggg4
Copy link
Author

@enchantinggg4 you can fix it with this :

.bracket-viewer {
  overflow-x: scroll;
  width: 100%;
}

Yeah sure, fix is simple just don't have enough time for it :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants