This repository has been archived by the owner on Jan 5, 2020. It is now read-only.
Fix Carthage Build #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am really appreciate for your great work, I tried to add Carthage support yesterday. But I cannot figure it out. Very very thanks again ~~ 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my previous pull request #5 something went wrong with the run schemes. Thus, when carthage tried to build the framework an error occurred.
I fixed the error with the schemes so now the project can be build via carthage. I tried building it using different versions of carthage and it worked flawlessly every time.
I also updated the README.md to contain carthage support and bumped CURRENT_PROJECT_VERSION to 1.3.
Sorry for the problems with my previous pull request. I am confident that everything is fixed now.