Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/drawer style #165

Merged
merged 3 commits into from
Nov 24, 2020
Merged

Fix/drawer style #165

merged 3 commits into from
Nov 24, 2020

Conversation

nicmosc
Copy link
Member

@nicmosc nicmosc commented Nov 24, 2020

https://www.notion.so/drawbotics/741a8736603341beb688859434b441ee?v=d4a4e6a36785431f869c3a1a84ea2000&p=88760b53e75c4a6cb66a84340829baae

  • Moves the close button to the right side
  • Allows any ReactNode as title props
  • Removes issue where onClickOverlay was deprecated but still required to close on click

image

@nicmosc nicmosc self-assigned this Nov 24, 2020
@nicmosc nicmosc added fix This PR fixes an issue minor Increment the minor version when merged labels Nov 24, 2020
github-actions[bot]
github-actions bot approved these changes Nov 24, 2020
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request contains a valid label.

github-actions[bot]
github-actions bot approved these changes Nov 24, 2020
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request contains a valid label.

github-actions[bot]
github-actions bot approved these changes Nov 24, 2020
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request contains a valid label.

@nicmosc nicmosc requested a review from larsbs November 24, 2020 14:28
@nicmosc nicmosc merged commit c9a5a42 into master Nov 24, 2020
@nicmosc nicmosc deleted the fix/drawer-style branch November 24, 2020 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larsbs larsbs larsbs approved these changes

@github-actions github-actions[bot] github-actions approved these changes

Assignees

@nicmosc nicmosc

Labels
fix This PR fixes an issue minor Increment the minor version when merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nicmosc @larsbs