handle null modules

Dream-mf · May 15, 2024 · 1cfe394 · 1cfe394
1 parent 2c6e500
commit 1cfe394
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/packages/dmf-core/package.json b/packages/dmf-core/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@dream.mf/core",
-  "version": "1.2.0",
+  "version": "1.2.1",
   "main": "dist/index.js",
   "module": "dist/index.mjs",
   "typings": "dist/index.d.ts",

diff --git a/packages/dmf-core/src/register.ts b/packages/dmf-core/src/register.ts
@@ -50,11 +50,15 @@ export const registerRuntimeRemote = (
     (item) => item.scope === scope,
   );
   if (!scopeExists) {
-    var record = { scope, modules: [module], url } as Remotes;
+    var record = {
+      scope,
+      modules: module == null ? [] : [module],
+      url,
+    } as Remotes;
     window[RuntimeName].remotes.push(record);
   } else {
     const s = window[RuntimeName].remotes.find((sc) => sc.scope === scope);
-    if (!s.modules.includes(module)) {
+    if (module !== null && !s.modules.includes(module)) {
       s.modules.push(module);
     }
   }