Re-enable markup frame type support

Dreamescaper · Oct 10, 2023 · ab45e10 · ab45e10
1 parent ae2b22e
commit ab45e10
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 4 deletions.
diff --git a/src/BlazorBindings.Core/NativeComponentAdapter.cs b/src/BlazorBindings.Core/NativeComponentAdapter.cs
@@ -255,7 +255,15 @@ private void RemoveChildElementAndDescendants(NativeComponentAdapter childToRemo
                 {
                     if (!string.IsNullOrWhiteSpace(frame.MarkupContent))
                     {
-                        throw new NotImplementedException($"Not supported frame type: {frame.FrameType}");
+                        if (_targetElement is IHandleChildContentText handleChildContentText)
+                        {
+                            handleChildContentText.HandleText(siblingIndex, frame.MarkupContent);
+                        }
+                        else
+                        {
+                            var typeName = _targetElement?.TargetElement?.GetType()?.Name;
+                            throw new NotImplementedException($"Element {typeName} does not support text content: " + frame.MarkupContent);
+                        }
                     }
                     // We don't need any adapter for Markup frames, but we care about frame position, therefore we simply insert null here.
                     Children.Insert(siblingIndex, null);

diff --git a/src/BlazorBindings.UnitTests/Elements/LabelTests.razor b/src/BlazorBindings.UnitTests/Elements/LabelTests.razor
@@ -17,6 +17,17 @@
         Assert.That(label.Text, Is.EqualTo("345"));
     }
 
+    [Test]
+    public async Task AddLabelWithMarkupContent()
+    {
+        var label = await Render<MC.Label>(
+    @<Label TextColor="Colors.White">
+        345
+    </Label>);
+
+        Assert.That(label.Text, Is.EqualTo("345"));
+    }
+
     [Test]
     public async Task AddLabelWithDynamicTextContent()
     {
@@ -66,9 +77,9 @@
         <Span>1</Span>
         <Span>2</Span>
         @if (insertSpan)
-        {
-            <Span>10</Span>
-        }
+    {
+        <Span>10</Span>
+    }
         <Span>3</Span>
     </Label>
     );