feat: add support to render label in slot area #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hitendreamworld
force-pushed
the
feature/update-form-field
branch
from
513e996
to
1a72b9e
Compare
dw-form-field.js
Outdated
|
|
||
| export class DwFormField extends Formfield { | ||
| static get styles() { | ||
| return [ | ||
| Formfield.styles, | ||
| css` | ||
| :host { | ||
| display: block; | ||
| display: inline-block; |
There was a problem hiding this comment.
Why display is changed to inline-block, we planned that we don't use inline-block in any new code, though?
| reflect: true | ||
| } | ||
| } | ||
| reflect: true, |
There was a problem hiding this comment.
this and following 2 lines changes seems extra, please avoid such extra changes.
dw-form-field.js
Outdated
|
|
||
| _renderLabel() { | ||
| if (this.label) { | ||
| return html`<label class="mdc-label" @click="${this._labelClick}" |
There was a problem hiding this comment.
What kind of formatting standards do you follow? Here, > is on the next line, same this happens for the closing tag. We need to meet once to learn & conclude formatting standards for HTML
hitendreamworld
changed the title
|
🎉 This PR is included in version 3.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.