wip: remove className from ExecClassData #117
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bodyangug
commented
Sep 8, 2023
bodyangug
commented
- change classId generation at instrument method()
- set up sharedLibsRef
- change classId generation at instrument method() - set up sharedLibsRef
|
Kudos, SonarCloud Quality Gate passed!
|
| @@ -149,7 +149,7 @@ class Test2Code( | |||
| .map { | |||
| ExecClassData( | |||
| id = it.id, | |||
| className = it.name, | |||
| nameId = it.nameId, | |||
There was a problem hiding this comment.
Main purpose of this task is to remove the className, since class is already identified by id.
I don't get why would we want to replace it with a hash value.
Lets discuss it again, I guess.
bodyangug
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.