Send coverage on jvm shutdown event #166
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EPMDJ-10866
RomanDavlyatshin
requested changes
Jul 2, 2024
| @@ -54,6 +54,10 @@ class IntervalCoverageSender( | |||
|
|
|||
| override fun stopSendingCoverage() { | |||
| scheduledThreadPool.shutdown() | |||
| if (!scheduledThreadPool.awaitTermination(5, TimeUnit.SECONDS)) { | |||
There was a problem hiding this comment.
I assume awaitTermination is required to have enough time to send coverage data.
I suggest to
if (!scheduledThreadPool.awaitTermination(5, TimeUnit.SECONDS)) {
logger.error("Failed to send some coverage data prior to shutdown") // signal to user that some coverage data is lost
scheduledThreadPool.shutdownNow();
}
If we'll get that error message a lot - we could investigate + make termination timeout configurable.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.