-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make properties, method protected rather than private #16
Comments
There are no contribution guidelines in the repo, but if you need I can do a PR although for something as simple I'd think it's more efficient if you guys do it 😬 |
That makes sense to me, feel free to make such a PR! I'm guessing that those of us who write Ruby most of the time forgot that Ruby private is closer to PHP protected. |
This just got released in 1.1.0. |
That was efficient! Thanks, much appreciated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We need to add methods to class
\Drip\Client
so we were looking at extending it with our custom class, adding the functionality that we need (and use that in our uses rather than the base class).But many properties and attributes in
Drip\Client
areprivate
; I don't see why they couldn't beprotected
instead? That would make it possible for others (like us) to extend it.The text was updated successfully, but these errors were encountered: