Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make properties, method protected rather than private #16

Closed
tdtm opened this issue Jul 25, 2018 · 4 comments
Closed

Make properties, method protected rather than private #16

tdtm opened this issue Jul 25, 2018 · 4 comments

Comments

@tdtm
Copy link

tdtm commented Jul 25, 2018

We need to add methods to class \Drip\Client so we were looking at extending it with our custom class, adding the functionality that we need (and use that in our uses rather than the base class).

But many properties and attributes in Drip\Client are private; I don't see why they couldn't be protected instead? That would make it possible for others (like us) to extend it.

@tdtm
Copy link
Author

tdtm commented Jul 25, 2018

There are no contribution guidelines in the repo, but if you need I can do a PR although for something as simple I'd think it's more efficient if you guys do it 😬

@will-in-wi
Copy link
Contributor

That makes sense to me, feel free to make such a PR! I'm guessing that those of us who write Ruby most of the time forgot that Ruby private is closer to PHP protected.

@will-in-wi
Copy link
Contributor

This just got released in 1.1.0.

@tdtm
Copy link
Author

tdtm commented Jul 26, 2018

That was efficient! Thanks, much appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants