Repair json parsing issues. #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eterry1388
approved these changes
Jun 6, 2018
CHANGELOG.md
Outdated
| @@ -10,6 +10,10 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0. | |||
|
|
|||
| - Your contribution here! | |||
|
|
|||
| ### Bugfix | |||
There was a problem hiding this comment.
Yup, it's been fixed
lib/drip/client.rb
Outdated
| @@ -116,7 +116,9 @@ def make_request(verb_klass, uri, options, step = 0) | |||
|
|
|||
| def build_response(&block) | |||
| response = yield | |||
| Drip::Response.new(response.code.to_i, response.body) | |||
| Drip::Response.new(response.code.to_i, response.body ? JSON.parse(response.body) : nil) | |||
There was a problem hiding this comment.
Could response.body be an empty string? If so, could use present?. Or could response.body every be false?
There was a problem hiding this comment.
Empty string triggers the JSON::ParserError and returns nil, which is correct.
It can't be false, and if it were, the result should be nil.
#present? comes from ActiveSupport, which we don't use here.
I've improved the empty string case to not require an exception, and added a test (which passed before the change).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #48