Big option refactor #243
Merged
Big option refactor #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 25 commits
August 23, 2023 14:31
Going through and seeing what's salvageable with the Option type. Maybe we keep the Option type, maybe we don't.
…ilities to Option List.
Not the tests of course... but progress.
jachin
merged commit e4702ca
into
235-allow-arbitrary-html-for-the-options-with-custom-elements
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a massive refactor where the
OptionListtype is introduced.Eventually, this will lead to Elm's type system providing more help. But right now, it just feels like a whole lot of code to change.